[Fedora-directory-devel] Please Review: (245665) dsalib still relies on server root

[Nathan Kinder]

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245665
Resolves: bug 245665
Bug Description: The dsa library in Admin Server still heavily relies on the
 concept of a server root.  This library is used by the Directory Server cgi
 tasks.

 The dsa library should try to get paths dynamically from the Directory 
Server
 config when possible.  Other paths that are not in the config, such as the
 location of command-line utilities, should be passed in as a define at
 compilation time.
Reviewed by: ???
Files: see diff
Branch: HEAD
Fix Description: This pass eliminated the usage of a "server root" in 
the dsa library.

  I also refactored some of the code that was referring to the "install 
root" as
  it did not seem to really represent the directory that it refers to.  
I renamed
  it to "instance dir" and adjusted the getter function and variables
  accordingly.  I needed to pass in the DS libdir as a define for being 
able to
  find the instance dir in the code.

  I also found that I was incorrectly using the lockdir config attribute 
to set
  the rundir, which was causing problems for the start, stop, and 
restart CGIs.
  We don't have the rundir in cn=config by default, but we already have 
it set as
  a PIDDIR define, so I opted to use that instead.  The start, stop, and 
restart
  CGIs now work properly.
Platforms tested: FC6
Flag Day: no
Doc impact: no
https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=157923&action=diff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3241 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/fedora-directory-devel/attachments/20070626/61e342ba/attachment.bin>