[Fedora-directory-devel] Please review: Bug 244475: crash at startup with new ldap sdk on 64-bit platform

[Richard Megginson]

https://bugzilla.redhat.com/show_bug.cgi?id=244475
Resolves: bug 244475
Bug Description: crash at startup with new ldap sdk on 64-bit platform
Reviewed by: ???
Files: see diff
Branch: HEAD
Fix Description: I went ahead and cleaned up or removed the incorrect 
ber code.  We do not need to use LBER_SOCKBUF_OPT_DESC or 
LBER_SOCKBUF_OPT_READ_FN or LBER_SOCKBUF_OPT_WRITE_FN.  I removed an 
unnecessary malloc/free and just used the stack as we do everywhere else 
in the code.  It looks as though the start_tls cleanup code is almost 
never used - the code assumes that when you do a start_tls, that stays 
in force throughout the lifetime of the connection.  Removing this code 
now should insulate us from future ldap c sdk changes.
Platforms tested: RHEL5 x86_64
Flag Day: no
Doc impact: no
https://bugzilla.redhat.com/attachment.cgi?id=221791&action=diff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/fedora-directory-devel/attachments/20071009/983d37ea/attachment.bin>