From nhosoi at redhat.com Wed Sep 5 01:18:28 2007 From: nhosoi at redhat.com (Noriko Hosoi) Date: Tue, 04 Sep 2007 18:18:28 -0700 Subject: [Fedora-directory-devel] Please review: [Bug 273501] Replication monitor CGI seems misconfigured In-Reply-To: <200709050054.l850sxUe006839@bz-web2.app.phx.redhat.com> References: <200709050054.l850sxUe006839@bz-web2.app.phx.redhat.com> Message-ID: <46DE03E4.5010103@redhat.com> Summary: Replication monitor CGI seems misconfigured https://bugzilla.redhat.com/show_bug.cgi?id=273501 Description of problem: >From the Admin Express: http://:/admin-serv/tasks/configuration/HTMLAdmin?op=index Click "Replication Status" Specify "Configuration file:" Click "OK" Result: http://:/admin-serv/tasks/configuration/HTMLAdmin?op=index Not Found The requested URL /admin-serv/tasks/configuration/repl-monitor-cgi.pl was not found on this server. --------- Additional Comments From nhosoi at redhat.com 2007-09-04 20:54 EST ------- Created an attachment (id=186751) --> (https://bugzilla.redhat.com/attachment.cgi?id=186751&action=view) cvs diffs (ldapserver) Modified File: ldapserver/ldap/admin/src/scripts/repl-monitor.pl Deleted File: ldapserver/ldap/admin/src/scripts/template-repl-monitor-cgi.pl.in Description: 1) get_replica: missing return value for the success case 2) support the case "shadowport" is not passed ------- Additional Comments From nhosoi at redhat.com 2007-09-04 21:00 EST ------- Created an attachment (id=186761) --> (https://bugzilla.redhat.com/attachment.cgi?id=186761&action=view) cvs diffs (adminserver) Modified Files: Makefile.am admserv/schema/ldif/21astasks.ldif.tmpl admserv/cgi-src40/monreplication.properties New File: ./admserv/cgi-src40/repl-monitor-cgi.pl.in (attaching next) Description: 1) added repl-monitor-cgi.pl(.in) 2) removed "perl?" from nsExecRef, with which CGI expects "perl" is in the cgi-bin directory ------- Additional Comments From nhosoi at redhat.com 2007-09-04 21:03 EST ------- Created an attachment (id=186771) --> (https://bugzilla.redhat.com/attachment.cgi?id=186771&action=view) adminserver/admserv/cgi-src40/repl-monitor-cgi.pl.in New file: adminserver/admserv/cgi-src40/repl-monitor-cgi.pl.in Description: it's moved from ldapserver/ldap/admin/src/scripts, and renamed from template-repl-monitor-cgi.pl to repl-monitor-cgi.pl. -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 3237 bytes Desc: S/MIME Cryptographic Signature URL: From nhosoi at redhat.com Thu Sep 6 23:04:01 2007 From: nhosoi at redhat.com (Noriko Hosoi) Date: Thu, 06 Sep 2007 16:04:01 -0700 Subject: [Fedora-directory-devel] Please review: [Bug 236256] verify-db.pl (db_verify) does not work on a little endian machine In-Reply-To: <200709062158.l86LwjaU022760@bz-web1.app.phx.redhat.com> References: <200709062158.l86LwjaU022760@bz-web1.app.phx.redhat.com> Message-ID: <46E08761.9060306@redhat.com> Summary: verify-db.pl (db_verify) does not work on a little endian machine https://bugzilla.redhat.com/show_bug.cgi?id=236256 Description of problem: If there is a index key that has more than 255 IDs in a secondary index b-tree, db_verify reports the b-tree is corrupted on a little endian machine. ------- Additional Comments From nhosoi at redhat.com 2007-09-06 17:58 EST ------- Created an attachment (id=189281) --> (https://bugzilla.redhat.com/attachment.cgi?id=189281&action=view) New File: ldapserver/ldap/servers/slapd/back-ldbm/dbverify.c Implemented dbverify function which calls Berkeley DB's DB->verify on each database file (.db# file). It works as a command line mode via dbverify script (being attached next). I've also implemented and tested the task mode, but DB->verify function does not like the way the DS opens the DB environment: [05/Sep/2007:18:41:16 -0700] - libdb: DB->verify may not be used with transactions, logging, or locking If we cannot share the DB environment, there is no much advantage to use the task mechanism, I think. Thus, I removed the task code for now. ------- Additional Comments From nhosoi at redhat.com 2007-09-06 18:09 EST ------- Created an attachment (id=189291) --> (https://bugzilla.redhat.com/attachment.cgi?id=189291&action=view) New File: ldapserver/ldap/admin/src/scripts/template-dbverify.in This is a template file to be instantiated when a server instance is created. Usage: dbverify [-n backend_instance] [-V] Note : if "-n backend_instance" is not passed, verify all DBs. -V : verbose Sample usages: $ dbverify DB verify: Passed $ dbverify -n userRoot DB verify: Passed $ dbverify -n bogus DB verify: Failed $ dbverify -V [...] DB verify - /var/lib/dirsrv/slapd-laputa2/db/userRoot/sn.db4: ok [...] DB verify - /var/lib/dirsrv/slapd-laputa2/db/userRoot/parentid.db4: ok [...] [...] DB verify - /var/lib/dirsrv/slapd-laputa2/db/userRoot/id2entry.db4: ok DB verify: Passed $ dbverify -V [...] DB verify - /var/lib/dirsrv/slapd-laputa3/db/userRoot/parentid.db4: ok [...] [...] - libdb: Page 0: nonsensical bt_minkey value 1 on metadata page [...] - libdb: Page 0: nonsensical root page 0 on metadata page [...] DB verify - verify failed(-30976): /var/lib/dirsrv/slapd-laputa3/db/userRoot/cn.db4 [...] [...] DB verify - /var/lib/dirsrv/slapd-laputa3/db/userRoot/id2entry.db4: ok DB verify: Failed ------- Additional Comments From nhosoi at redhat.com 2007-09-06 18:17 EST ------- Created an attachment (id=189301) --> (https://bugzilla.redhat.com/attachment.cgi?id=189301&action=view) cvs diffs Modified Files: Makefile.am ldap/admin/src/scripts/template-verify-db.pl.in ldap/servers/slapd/main.c ldap/servers/slapd/pblock.c ldap/servers/slapd/slap.h ldap/servers/slapd/slapi-private.h ldap/servers/slapd/task.c ldap/servers/slapd/back-ldbm/dblayer.c ldap/servers/slapd/back-ldbm/init.c ldap/servers/slapd/back-ldbm/proto-back-ldbm.h Descriptions: 1) adding dbverify (template-dbverify.in) 2) adding dbverify.c 3) updating verify-db.pl calling dbverify instead of db_verify from Berkeley DB 4) updating main.c/pblock.c/slap.h/slapi-private.c to make dbverify mode available 5) fixing minor memory leak (task.c) and mode confusion (dblayer.c) Sample usages: $ verify-db.pl ***************************************************************** verify-db: This tool should only be run if recovery start fails and the server is down. If you run this tool while the server is running, you may get false reports of corrupted files or other false errors. ***************************************************************** Verify log files in /var/lib/dirsrv/slapd-laputa2/db ... Good Verify db files ... Good $ verify-db.pl ***************************************************************** verify-db: This tool should only be run if recovery start fails and the server is down. If you run this tool while the server is running, you may get false reports of corrupted files or other false errors. ***************************************************************** Verify log files in /var/lib/dirsrv/slapd-laputa3/db ... Good Verify db files ... [...] - libdb: Page 0: nonsensical bt_minkey value 1 on metadata page [...] - libdb: Page 0: nonsensical root page 0 on metadata page [...] DB verify - verify failed(-30976): /var/lib/dirsrv/slapd-laputa3/db/userRoot/cn.db4 Found the index file(s) was corrupted Please run db2index on the corrupted index -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 3237 bytes Desc: S/MIME Cryptographic Signature URL: From rmeggins at redhat.com Thu Sep 6 23:10:15 2007 From: rmeggins at redhat.com (Richard Megginson) Date: Thu, 06 Sep 2007 17:10:15 -0600 Subject: [Fedora-directory-devel] Please review: Bug 281631: Pass in schema and config LDIF files to setup Message-ID: <46E088D7.1080900@redhat.com> https://bugzilla.redhat.com/show_bug.cgi?id=281631 Resolves: bug 281631 Bug Description: Pass in schema and config LDIF files to setup Reviewed by: ??? Files: see diff Branch: HEAD Fix Description: 1) Allow multi-valued parameters in .inf files and command line. These values will be represented internally as an array ref. No existing parameters allow being multi-valued (e.g. you can't use Suffix=o=foo and Suffix=o=bar) 2) Add two new .inf parameters - SchemaFile and ConfigFile. The files listed in SchemaFile will be copied into the schema subdirectory of the new instance, so they must already be named appropriately (e.g. 60foo.ldif). The files listed in ConfigFile must be LDIF files with one or more whole entries to be added to the initial dse.ldif. These could be additional suffixes/databases to create, plugin configuration, replication configuration, or anything else. Right now, if you have an LDIF file that relies on custom schema, you cannot use the InstallLdifFile directive during setup. SchemaFile allows you to do that. Platforms tested: RHEL5 Flag Day: no Doc impact: Will need to document the two additional parameters. https://bugzilla.redhat.com/attachment.cgi?id=189321 -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 3245 bytes Desc: S/MIME Cryptographic Signature URL: From rmeggins at redhat.com Fri Sep 7 16:08:11 2007 From: rmeggins at redhat.com (Richard Megginson) Date: Fri, 07 Sep 2007 10:08:11 -0600 Subject: [Fedora-directory-devel] Please review: Bug 244475: crash at startup with new ldap sdk on 64-bit platform Message-ID: <46E1776B.4010903@redhat.com> https://bugzilla.redhat.com/show_bug.cgi?id=244475 Resolves: bug 244475 Bug Description: crash at startup with new ldap sdk on 64-bit platform Reviewed by: ??? Files: see diff Branch: HEAD Fix Description: Use LBER_SOCKET as the socket type instead of int. There was also a place in ldclt where we were doing the same thing. Platforms tested: RHEL5 x86_64 Flag Day: no Doc impact: no https://bugzilla.redhat.com/attachment.cgi?id=190111 -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 3245 bytes Desc: S/MIME Cryptographic Signature URL: From rmeggins at redhat.com Tue Sep 11 22:14:54 2007 From: rmeggins at redhat.com (Richard Megginson) Date: Tue, 11 Sep 2007 16:14:54 -0600 Subject: [Fedora-directory-devel] Please review: Bug 283041: MMR: Directory updates on same object Message-ID: <46E7135E.1020006@redhat.com> https://bugzilla.redhat.com/show_bug.cgi?id=283041 Resolves: bug 283041 Bug Description: MMR: Directory updates on same object Reviewed by: ??? Files: see diff Branch: HEAD Fix Description: https://bugzilla.redhat.com/show_bug.cgi?id=283041#c2 Platforms tested: RHEL5 x86_64 Flag Day: no Doc impact: no https://bugzilla.redhat.com/attachment.cgi?id=192941&action=diff -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 3245 bytes Desc: S/MIME Cryptographic Signature URL: From rmeggins at redhat.com Tue Sep 18 16:20:48 2007 From: rmeggins at redhat.com (Richard Megginson) Date: Tue, 18 Sep 2007 10:20:48 -0600 Subject: [Fedora-directory-devel] Please review: Bug 295001: Migration - Can't Start Admin Server Message-ID: <46EFFAE0.3040003@redhat.com> https://bugzilla.redhat.com/show_bug.cgi?id=295001 Resolves: bug 295001 Bug Description: Migration - Can't Start Admin Server Reviewed by: ??? Files: see diff Branch: HEAD Fix Description: The migration script was clobbering console.conf instead of replacing the Group information. Platforms tested: RHEL5 x86_64 Flag Day: no Doc impact: no QA impact: should be covered by regular nightly and manual testing New Tests integrated into TET: none https://bugzilla.redhat.com/attachment.cgi?id=198541&action=diff -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 3245 bytes Desc: S/MIME Cryptographic Signature URL: From nkinder at redhat.com Thu Sep 20 22:31:09 2007 From: nkinder at redhat.com (Nathan Kinder) Date: Thu, 20 Sep 2007 15:31:09 -0700 Subject: [Fedora-directory-devel] Please Review: (299361) Sync total update doesn't handle initials and streetAddress properly Message-ID: <46F2F4AD.7000606@redhat.com> https://bugzilla.redhat.com/show_bug.cgi?id=299361 esolves: bug 299361 Bug Description: There are some problems with the sync total update in regards to the initials and streetAddress attributes. The code currently doesn't handle multi-valued streetAddress attributes or initials attributes longer than 6 characters in the entries on the DS side. When you do an initialization with these types of entries, the sync fails due to constraints on the AD side. We already handle these values properly in the incremental sync protocol. Reviewed by: ??? Files: see diff Branch: HEAD Fix Description: This fix trims the initials attribute when sending to AD. We also only compare the first 6 characters of an initials value in DS to the initials value in AD when determining if we need to send a change. For streetAddress, we only sync one value from DS to AD. We check if DS contains the streetAddress value present in AD to determine if we need to accept a change from AD. Platforms tested: FC6 & Windows 2003 Server Flag Day: no Doc impact: no QA impact: Need to add new tests New Tests integrated into TET: none https://bugzilla.redhat.com/attachment.cgi?id=201401&action=diff -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 3241 bytes Desc: S/MIME Cryptographic Signature URL: From nhosoi at redhat.com Sat Sep 22 01:56:48 2007 From: nhosoi at redhat.com (Noriko Hosoi) Date: Fri, 21 Sep 2007 18:56:48 -0700 Subject: [Fedora-directory-devel] Please review: [Bug 171081] ldapsearch hung at browsing index creation In-Reply-To: <200709220150.l8M1o7Dx028742@bz-web2.app.phx.redhat.com> References: <200709220150.l8M1o7Dx028742@bz-web2.app.phx.redhat.com> Message-ID: <46F47660.9020209@redhat.com> Summary: ldapsearch hung at browsing index creation https://bugzilla.redhat.com/show_bug.cgi?id=171081 This bug was introduced while fixing another bug: deleting a vlv index while it's being created makes the server crash. ------- Additional Comments From nhosoi at redhat.comhttps://bugzilla.redhat.com/attachment.cgi?id=202891&action=view) cvs diff ldif2ldbm.c vlv.c Files: ldapserver/ldap/servers/slapd/back-ldbm/ldif2ldbm.c vlv.c Fix Description: 1. instead of covering all the reindexing loop, set vlv lock just around vlv_update_index, where vlv update is executed. 2. actually, lock is not meant to use for excluding the operation against vlv reconfiguration. This ldbm_back_ldbm2index function first calls instance_set_busy_and_readonly and protects the backend from the operations done by other threads. vlv delete call was just ignoring the busy/readonly setting. Thus, changed the vlv code to respect the setting. Found the backend is busy, deleting a vlv index fails and returns. 3. cleaned up the instance_set_busy_and_readonly function not to leak memory. 4. fixed minor memory leak. Thanks, --noriko -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 3237 bytes Desc: S/MIME Cryptographic Signature URL: From nkinder at redhat.com Mon Sep 24 22:07:02 2007 From: nkinder at redhat.com (Nathan Kinder) Date: Mon, 24 Sep 2007 15:07:02 -0700 Subject: [Fedora-directory-devel] Please Review: (304191) dbscan doesn't handle RUV entries in changelog db Message-ID: <46F83506.8070906@redhat.com> https://bugzilla.redhat.com/show_bug.cgi?id=304191 Resolves: bug 304191 Bug Description: If you try to run the dbscan tool against a changelog db on a stopped server, it reports the an error similar to: dbid: 0000006f000000000000 Invalid changelog db version 1 Works for version 5 only. Reviewed by: ??? Files: see diff Branch: HEAD Fix Description: The print_changelog function in dbscan.c expects all entries to have 0x05 as the first byte, which signifies the changelog version. This version check should be done for all change entries in the changelog db, but there are three special entries that are in the beginning of the changelog where this doesn't apply. These entries are an entry count, the purge RUV, and the max RUV. It should be noted that these entries are not always present when the server is running, so dbscan will often work fine against a running server. When the server is stopped gracefully, these entries are flushed out to be used once the server is restarted. The attached diffs make dbscan check for these special entries when reading through a changelog. If it encounters one of these entries, it will print out the data in a nice usable format. Platforms tested: FC6 i386 Flag Day: no Doc impact: no QA impact: Need to add new tests New Tests integrated into TET: none https://bugzilla.redhat.com/attachment.cgi?id=204611&action=diff -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 3241 bytes Desc: S/MIME Cryptographic Signature URL: From nhosoi at redhat.com Tue Sep 25 21:00:04 2007 From: nhosoi at redhat.com (Noriko Hosoi) Date: Tue, 25 Sep 2007 14:00:04 -0700 Subject: [Fedora-directory-devel] Please review: [Bug 241089] reset db statistics between restarts In-Reply-To: <200709252055.l8PKthES004581@bz-web2.app.phx.redhat.com> References: <200709252055.l8PKthES004581@bz-web2.app.phx.redhat.com> Message-ID: <46F976D4.4040309@redhat.com> Summary: reset db statistics between restarts https://bugzilla.redhat.com/show_bug.cgi?id=241089 Since DS 7.x retains the db region files between restarts, the database statistics are not reset. Although the cache region contains pages that were cached before the restart, I think it still makes sense to expect stats like dbcachehits to be calculated from startup to match the entrycache monitor. Maybe we can call db->memp_stat() with the DB_STAT_CLEAR when we shut down or start up? ------- Additional Comments From nhosoi at redhat.com 2007-09-25 16:55 EST ------- Created an attachment (id=206121) --> (https://bugzilla.redhat.com/attachment.cgi?id=206121&action=view) cvs diff (back-ldbm) Thanks to Ulf for reporting the problem and the suggestion to fix it. The proposed diff cleans up the db stats when the server is shutdown. -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 3237 bytes Desc: S/MIME Cryptographic Signature URL: From nhosoi at redhat.com Thu Sep 27 16:46:28 2007 From: nhosoi at redhat.com (Noriko Hosoi) Date: Thu, 27 Sep 2007 09:46:28 -0700 Subject: [Fedora-directory-devel] Please review: [Bug 251090] ds_remove cannot remove/rename directories In-Reply-To: <200709271623.l8RGNBYj020757@bz-web2.app.phx.redhat.com> References: <200709271623.l8RGNBYj020757@bz-web2.app.phx.redhat.com> Message-ID: <46FBDE64.7020107@redhat.com> Summary: ds_remove cannot remove/rename directories https://bugzilla.redhat.com/show_bug.cgi?id=251090 Problem: DS instance removal from the Console fails to clean up the instance dir and the config dir when the server user and the install user are different. The instance creation runs as the install user, while the deletion does as the server user. Changed the deletion privilege to the install user. ------- Additional Comments From nhosoi at redhat.com 2007-09-27 12:23 EST ------- Created an attachment (id=208571) --> (https://bugzilla.redhat.com/attachment.cgi?id=208571&action=view) Problem description ------- Additional Comments From nhosoi at redhat.com 2007-09-27 12:35 EST ------- Created an attachment (id=208641) --> (https://bugzilla.redhat.com/attachment.cgi?id=208641&action=view) cvs diffs Files: adminserver: admserv/cfgstuff/admserv.conf.in admserv/schema/ldif/10dsdata.ldif.tmpl mod_restartd: mod_restartd/mod_restartd.c Changes: 1) let ds_remove (CGI) run with the root permission. 2) acl names for SIE group were identical for all the DS instances: "SIE Group", which should be different for each instance. Thanks, --noriko -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 3237 bytes Desc: S/MIME Cryptographic Signature URL: From nhosoi at redhat.com Fri Sep 28 20:04:28 2007 From: nhosoi at redhat.com (Noriko Hosoi) Date: Fri, 28 Sep 2007 13:04:28 -0700 Subject: [Fedora-directory-devel] Please review: [Bug 222918] server crash after deleting supposedly deleted attribute In-Reply-To: <200709281952.l8SJqM2r018505@bz-web1.app.phx.redhat.com> References: <200709281952.l8SJqM2r018505@bz-web1.app.phx.redhat.com> Message-ID: <46FD5E4C.8050006@redhat.com> Summary: server crash after deleting supposedly deleted attribute https://bugzilla.redhat.com/show_bug.cgi?id=222918 On some configuration, FDS1.0.2 crashes when handling these modify requests: dn: cuniPersonalId=99853826,ou=people,dc=cuni,dc=cz changetype: modify replace: cuniPrincipalName - dn: cuniPersonalId=99853826,ou=people,dc=cuni,dc=cz changetype: modify delete: cuniPrincipalName ------- Additional Comments From nhosoi at redhat.com 2007-09-28 15:52 EST ------- Created an attachment (id=210881) --> (https://bugzilla.redhat.com/attachment.cgi?id=210881&action=view) cvs diffs Files: servers/plugins/syntaxes/string.c servers/slapd/back-ldbm/index.c Description: I tried to reproduce the problem, but it failed. I tried the test under the stress with nsslapd-serial-lock: off, but the condition was not the key. My test always catches: ldap_modify: No such attribute at the second deletion, with which it does not take the crash path. I tried indexed attribute as well as unindexed, but no luck. Anyway, although I could not reproduce the crash, but the stacktrace in the original comment indicates even if there is no attribute to delete, it calls index_addordel_values_sv with NULL vals, which is not supposed to, I think. Also, string_values2keys in string.c is not ready to accept NULL bvals. I changed these two files so that even if the condition is realized, the server won't crash. -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 3237 bytes Desc: S/MIME Cryptographic Signature URL: From mccann at jhu.edu Fri Sep 28 23:30:08 2007 From: mccann at jhu.edu (William Jon McCann) Date: Fri, 28 Sep 2007 19:30:08 -0400 Subject: [Fedora-directory-devel] patch to fix ambiguity in imported classes Message-ID: <939dd5750709281630w58152340te66d6a49dc54e345@mail.gmail.com> Hi, I was trying to "ant package" the console stuff from cvs and ran into some errors using java 1.6. It seems like using import with a wildcard in some cases pulls in two classes with the same name. Here is a patch that replaces some of these problematic wildcards with explicit imports. I'm not really a java hacker so I'm not sure this is the best approach but it seems to make sense to me. Thanks, Jon -------------- next part -------------- A non-text attachment was scrubbed... Name: console-ambiguous.diff Type: text/x-diff Size: 6530 bytes Desc: not available URL: