[Fedora-directory-devel] Please review: Bug 462411 - certificate request wizard returns an error

Rich Megginson rmeggins at redhat.com
Tue Dec 2 23:38:51 UTC 2008


https://bugzilla.redhat.com/show_bug.cgi?id=462411
Resolves: bug 462411
Bug Description: certificate request wizard returns an error
Reviewed by: ???
Files: see diff
Branch: HEAD
Fix Description: This was broken as part of the fix for the XSS issues. 
To fix that, in order to make sure we never displayed any string that 
contained unescaped HTML entities, we just go ahead and escape 
everything when we read the values from the CGI GET or POST arguments.   
For this particular bug, this meant the cert CGI was getting a DN like 
this: CN="ldap.example.com" instead of CN="ldap.example.com".  
The solution is to add some functions to adminutil (stolen from dsgw) 
that can be used to escape/unescape HTML entities.  We have to be 
careful never to display unescaped strings - in this particular case, 
the DN is never printed.
Platforms tested: RHEL5
Flag Day: yes - will require new adminutil, adminserver
Doc impact: no
https://bugzilla.redhat.com/attachment.cgi?id=325446&action=diff
https://bugzilla.redhat.com/attachment.cgi?id=325447&action=diff




More information about the Fedora-directory-devel mailing list