[Fedora-directory-devel] Please Review: (470918) replica_set_updatedn does not handle modifications of type ldap_add correctly

[Nathan Kinder]

https://bugzilla.redhat.com/show_bug.cgi?id=470918
Resolves: bug 470918
Bug Description: The replica_set_updatedn() checks the type of modify 
operation that
  it is dealing with by checking if specific bits are set when the 
replica update DN
  attribute is being modified.  The problem is that the value of 
LDAP_MOD_ADD is 0,
  so you can't use a simple bit check.
Reviewed by: ???
Files: see diff
Branch: HEAD
Fix Description: The fix is to check the value of the modify operation 
type instead
  of doing a simple bit check.  We need to be careful to exclude the bit 
flag for
  LDAP_MOD_BVALUES since it could be set along with any of the modify op 
types.
Platforms tested: Fedora 8
Flag Day: no
Doc impact: no
https://bugzilla.redhat.com/attachment.cgi?id=323481&action=diff