[389-devel] Please Review: (514955) Don't replicate DNA generation mod
Nathan Kinder
nkinder at redhat.com
Mon Aug 3 17:05:30 UTC 2009
On 08/03/2009 09:17 AM, Noriko Hosoi wrote:
> On 08/03/2009 09:06 AM, Nathan Kinder wrote:
>> On 07/31/2009 03:16 PM, Nathan Kinder wrote:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=514955
>> The previous patch did not handle all cases. This new patch takes a
>> different approach
>> than the previous patch. Instead of trimming the mod that triggered
>> generation, we leave
>> it alone and make DNA check subsequent mods before commiting to
>> generating a new
>> value. This is easily done by just unsetting the generate flag if we
>> find a subsequent
>> mod for the same attribute in the same operation.
> Looks good.
> --noriko
Pushed to master. Thanks for the review!
>>> ------------------------------------------------------------------------
>>>
>>> --
>>> 389-devel mailing list
>>> 389-devel at redhat.com
>>> https://www.redhat.com/mailman/listinfo/fedora-directory-devel
>>>
>>
>> ------------------------------------------------------------------------
>>
>> --
>> 389-devel mailing list
>> 389-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/fedora-directory-devel
>>
>
> ------------------------------------------------------------------------
>
> --
> 389-devel mailing list
> 389-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/fedora-directory-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/fedora-directory-devel/attachments/20090803/82ae76e7/attachment.htm>
More information about the Fedora-directory-devel
mailing list