[Fedora-directory-devel] Please review: Bug 468474 - migration results in incomplete admin server sie

[Rich Megginson]

https://bugzilla.redhat.com/show_bug.cgi?id=468474
Resolves: bug 468474
Bug Description: migration results in incomplete admin server sie
Reviewed by: ???
Files: see diff
Branch: HEAD
Fix Description: This is a redesign of one of the core pieces of the 
setup/migration code - the code that adds the LDAP entries in various 
places.  For starters, I removed the code that would implicitly delete 
existing trees.  This is the root cause of this bug, and other similar 
problems with setup/instance creation that have been reported.  We 
should never implicitly delete entries.  Instead, we should explicitly 
delete entries by using the changetype: delete in an LDIF template file.
Another source of problems was that to update an entry, we would delete 
it and add it back.  This caused some configuration settings to be wiped 
out (e.g. encryption settings).  We cannot do this any more.  The LDIF 
template entries have been modified to have two sets of information for 
each entry that requires update - the entry to add if no entry exists 
(the full entry) or the changes to make to the entry if it does exist.  
The code in Util.pm has been changed to ignore duplicate entries and to 
ignore changes made to entries that do not exist.
Another source of problems with migration is that the error checking was 
not adequate, especially with FileConn and dse.ldif reading.  The fix is 
to add better error checking and reporting in these areas of code, 
including error messages.
Yet another problem is the run_dir handling.  On many platforms the 
run_dir is shared among all DS instances and the admin server.  Older 
versions of the software allowed you to run the servers as root.  We 
have to make sure run_dir is usable by the least privileged user of all 
of the servers.
Platforms tested: RHEL4
Flag Day: no
Doc impact: no
https://bugzilla.redhat.com/attachment.cgi?id=332973&action=diff
https://bugzilla.redhat.com/attachment.cgi?id=332974&action=diff