[Fedora-directory-devel] Please review: Bug 471068 - winsync doesn't recognize some changes

[Rich Megginson]

https://bugzilla.redhat.com/show_bug.cgi?id=471068
Resolves: bug 471068
Bug Description: winsync doesn't recognize some changes
Reviewed by: ???
Files: see diff
Branch: HEAD
Fix Description: Before sending updates to AD, first check to see if the 
updates still apply.  For modify/add operations, check to make sure the 
value to add doesn't exist.  If it does, remove it from the list of 
values in the mod.  If all values are removed, then just skip the 
modify/add op altogether.  For modify/del ops, check to see if the 
attribute exists.  If not, just skip the op.  If it does exist, check to 
see if the values exist, and remove the values from the mod/del op that 
do not exist anymore.  If all values have been removed, just skip the 
mod/del op.
I added a new slapi function - slapi_mod_init_valueset_byval - which 
will init a Slapi_Mod and init the list of values using a valueset.  
Fortunately there was already a function for converting a Slapi_Value** 
to a berval**.
I also fixed a few compiler warnings.
Platforms tested: RHEL5
Flag Day: no
Doc impact: yes - add new function to slapi docs
https://bugzilla.redhat.com/attachment.cgi?id=328589&action=diff