[Fedora-directory-devel] Please review: Bug 204966 - WinSync ignores entry if NT attributes are added later.

[Rich Megginson]

https://bugzilla.redhat.com/show_bug.cgi?id=204966
Resolves: bug 204966
Bug Description: WinSync ignores entry if NT attributes are added later.
Reviewed by: ???
Files: see diff
Branch: HEAD
Fix Description: If we are replaying a modify operation, we need to 
check if the ntUser objectclass is being added along with the other 
attributes that tell the sync service to sync this entry.  If the 
objectclass is being added or replaced, we check the existing entry to 
see if it is still a sync-able entry.  If it is, we call 
process_replay_add to add the entry.  I changed this function to accept 
a Slapi_Entry to add rather than the operation structure.  Finally, I 
had to change the way we send the Account Control flags to take into 
account an entry that may have been added as a result of a modify operation.
I fixed a memory leak when setting the Slapi_Attr attribute type, and 
cleaned up a compiler warning.
NOTE: There will be no clear text password to send (unless the 
userPassword was modified in the same modify operation).  This means the 
account will be added to Windows, and will be enabled, but will be 
essentially unusable - the user cannot login - until either the user 
modifies the password on the directory server side, or the administrator 
resets the password.
Platforms tested: RHEL5
Flag Day: no
Doc impact: yes - we will have to document the new winsync behavior
https://bugzilla.redhat.com/attachment.cgi?id=328818&action=diff