[Fedora-directory-devel] Please Review: (430364) setup-ds-admin.pl does not correctly set the admin server ip address

[Nathan Kinder]

https://bugzilla.redhat.com/show_bug.cgi?id=430364
Resolves: bug 430364
Bug Description: When the IP address for the admin server to listen on
  is specified in the inf file, it is not used in the config DS or in
  the console.conf config file.
Reviewed by: ???
Files: see diff
Branch: HEAD
Fix Description: The first issue is that an error was being returned by the
  config CGI when attempting to set the IP address in console.conf, but the
  AdminServer.pm code was not detecting this error.  This caused the install
  to not error out reporting that there was a problem with the IP address.

  The second issue is that the validation of the IP address in the 
config CGI was
  too strict.  To validate the IP address, we were getting the hostname 
of the
  system, doing a reverse lookup to get the addresses associated with that
  hostname, then checking if any of those addresses matched the one form 
the .inf
  file.  If the requested address is assigned to a different hostname, this
  validation will fail.  The fix is to simply try to bind the address to 
a socket
  to see if the address is valid.  We don't need to care what hostname it is
  associated with, we just need to know that the address is assigned to the
  system.

  The third issue is that the template file for the "o=NetscapeRoot" 
entry was
  missing a replace macro for the "nsServerAddress" attribute.  The fix 
just adds
  the macro and maps it to the ServerIpAddress .inf directive.
Platforms tested: F9
Flag Day: no
Doc impact: no
https://bugzilla.redhat.com/attachment.cgi?id=330174&action=diff