<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> On 08/03/2009 09:17 AM, Noriko Hosoi wrote: <blockquote cite="mid:4A770DA8.7030702@redhat.com" type="cite"> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> On 08/03/2009 09:06 AM, Nathan Kinder wrote: <blockquote cite="mid:4A770B20.7090103@redhat.com" type="cite"> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> On 07/31/2009 03:16 PM, Nathan Kinder wrote: <blockquote cite="mid:4A736D27.5050503@redhat.com" type="cite"><a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://bugzilla.redhat.com/show_bug.cgi?id=514955">https://bugzilla.redhat.com/show_bug.cgi?id=514955</a> </blockquote> The previous patch did not handle all cases. This new patch takes a different approach than the previous patch. Instead of trimming the mod that triggered generation, we leave it alone and make DNA check subsequent mods before commiting to generating a new value. This is easily done by just unsetting the generate flag if we find a subsequent mod for the same attribute in the same operation. </blockquote> Looks good. --noriko </blockquote> Pushed to master. Thanks for the review! <blockquote cite="mid:4A770DA8.7030702@redhat.com" type="cite"> <blockquote cite="mid:4A770B20.7090103@redhat.com" type="cite"> <blockquote cite="mid:4A736D27.5050503@redhat.com" type="cite"> <pre wrap=""><hr size="4" width="90%"> -- 389-devel mailing list <a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:389-devel@redhat.com">389-devel@redhat.com</a> <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/fedora-directory-devel">https://www.redhat.com/mailman/listinfo/fedora-directory-devel</a> </pre> </blockquote> <pre wrap=""><hr size="4" width="90%"> -- 389-devel mailing list <a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:389-devel@redhat.com">389-devel@redhat.com</a> <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/fedora-directory-devel">https://www.redhat.com/mailman/listinfo/fedora-directory-devel</a> </pre> </blockquote> <pre wrap=""> <hr size="4" width="90%"> -- 389-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:389-devel@redhat.com">389-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/fedora-directory-devel">https://www.redhat.com/mailman/listinfo/fedora-directory-devel</a> </pre> </blockquote> </body> </html>