<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Thanks for the review, Rich!<br>
<br>
Pushed to master.<br>
<br>
$ git merge usn<br>
Updating 177f772..6b08e5b<br>
Fast forward<br>
ldap/servers/plugins/replication/repl5_agmt.c | 136
+++++++++++++++++----<br>
ldap/servers/plugins/usn/usn.c | 40 +++++-<br>
ldap/servers/plugins/usn/usn.h | 2 +-<br>
ldap/servers/slapd/dse.c | 7 +-<br>
ldap/servers/slapd/plugin.c | 156
+++++++++++++++++++++++++<br>
ldap/servers/slapd/proto-slap.h | 2 +-<br>
ldap/servers/slapd/slapi-plugin.h | 23 ++++<br>
ldap/servers/slapd/slapi-private.h | 2 +<br>
8 files changed, 329 insertions(+), 39 deletions(-)<br>
$ git push<br>
Counting objects: 31, done.<br>
Delta compression using 4 threads.<br>
Compressing objects: 100% (16/16), done.<br>
Writing objects: 100% (16/16), 5.66 KiB, done.<br>
Total 16 (delta 13), reused 0 (delta 0)<br>
To ssh://git.fedorahosted.org/git/389/ds.git<br>
177f772..6b08e5b master -> master<br>
<br>
On 08/31/2009 07:22 AM, Rich Megginson wrote:
<blockquote cite="mid:4A9BDC88.9030903@redhat.com" type="cite">Noriko
Hosoi wrote:
<br>
<blockquote type="cite">Thanks to Endi and Rich for their comments to
improve the functionality. I changed the slapi APIs to take and return
the Slapi_Value(Set) to support any data type other than string.
<br>
<br>
New slapi APIs in libslapd:
<br>
int slapi_set_plugin_default_config(const char *type, Slapi_Value
*value);
<br>
Description: Add given "type: value" to the plugin default config
entry
<br>
(cn=plugin default config,cn=config) unless the same
"type:
<br>
value" pair already exists in the entry.
<br>
Parameters: type - Attribute type to add to the default config entry
<br>
value - Attribute value to add to the default config entry
<br>
Return Value: 0 if the operation was successful
<br>
non-0 if the operation was not successful
<br>
<br>
int slapi_get_plugin_default_config(char *type, Slapi_ValueSet
**valueset);
<br>
Description: Get attribute values of given type from the plugin
default
<br>
config entry (cn=plugin default config,cn=config).
<br>
Parameters: type - Attribute type to get from the default config entry
<br>
valueset Valueset holding the attribute values
<br>
Return Value: 0 if the operation was successful
<br>
non-0 if the operation was not successful
<br>
warning: Caller is responsible to free attrs by slapi_ch_array_free
<br>
<br>
Thanks,
<br>
--noriko
<br>
</blockquote>
Looks good. ack
<br>
<blockquote type="cite"><br>
<br>
------------------------------------------------------------------------
<br>
<br>
--
<br>
389-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:389-devel@redhat.com">389-devel@redhat.com</a>
<br>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/fedora-directory-devel">https://www.redhat.com/mailman/listinfo/fedora-directory-devel</a>
<br>
</blockquote>
<br>
<pre wrap="">
<hr size="4" width="90%">
--
389-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:389-devel@redhat.com">389-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/fedora-directory-devel">https://www.redhat.com/mailman/listinfo/fedora-directory-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>