[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Regression alert for redhat.xsl (was Re: xsl redhat.xsl,1.1,1.2)



For those not on the commits list ... or overwhelmed by the entries this
week ...

I checked in a change to redhat.xsl that caused a build error in the
install-guide module.  This change to the XSL had been to support the
no-chunking (single HTML file output from DocBook) that James Laska
patched.  The no-chunking is working great, but this particular change
isn't.  This is me checking my local 1.2 against the 1.3 version that
caused the regression:

[kwade erato xsl]$ diff -u redhat.xsl.~1.2.~ redhat.xsl
--- redhat.xsl.~1.2.~   2003-10-01 12:02:56.000000000 -0700
+++ redhat.xsl  2005-05-30 12:05:47.000000000 -0700
@@ -7,7 +7,6 @@
                version="1.0"
                 exclude-result-prefixes="exsl">

-<xsl:import href="/usr/share/sgml/docbook/xsl-stylesheets/html/docbook.xsl"/>

 <!-- This sets the extension for HTML files to ".html".     -->
 <!-- (The stylesheet's default for XHTML files is ".xhtm".) -->

I reverted the XSL to 1.2 and tried it out locally.  Both the
Installation Guide (chunking) and the Release Notes (no-chunking) built
ok.  For the FC4 release, those are the only two we care about.

James, what problems did you have with the docbook.xsl being imported at
that point in redhat.xsl?

- Karsten
On Wed, 2005-06-01 at 19:58 -0400, Karsten Wade wrote:
> Author: kwade
> 
> Update of /cvs/docs/xsl
> In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv14057
> 
> Modified Files:
> 	redhat.xsl 
> Log Message:
> This is probably the wrong way to do this, I reverted to 1.1 when I
> meant to rever to 1.2, so I am now recommitting 1.2.  The version in
> 1.3 caused a regression in the Installation Guide and I'm sure all
> other guides.  Ver. 1.3 had removed the import of docbook.xsl, which
> caused the build to fail.  I tested this version 1.2 on release-
> notes/FC4/ and the install-guide/ and it seems to work with chunking
> and non-chunking.  I will talk with jlaska and find out why he removed
> this call ... I know it broke something for them.  Further regressions
> are a possibility, just hopefully not in the only two documents that
> we *must* have build for FC4.
> 
> 
> Index: redhat.xsl
> ===================================================================
> RCS file: /cvs/docs/xsl/redhat.xsl,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- redhat.xsl	17 Jul 2003 19:48:07 -0000	1.1
> +++ redhat.xsl	1 Jun 2005 23:58:27 -0000	1.2
> @@ -1,4 +1,4 @@
> -<!-- created by Tammy Fox tfox redhat com for the RHL Project -->
> +<!-- created by Tammy Fox tfox redhat com for the Fedora Project -->
>  <!-- License: GPL -->
>  <!-- Copyright 2003 Tammy Fox, Red Hat, Inc. -->



-- 
Karsten Wade, RHCE * Sr. Tech Writer * http://people.redhat.com/kwade/
gpg fingerprint:  2680 DBFD D968 3141 0115    5F1B D992 0E06 AD0E 0C41   
                       Red Hat SELinux Guide
http://www.redhat.com/docs/manuals/enterprise/RHEL-4-Manual/selinux-guide/

Attachment: signature.asc
Description: This is a digitally signed message part


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]