rpms/enemies-of-carlotta/devel enemies-of-carlotta-1.0.3-Makefile.patch, NONE, 1.1 enemies-of-carlotta.spec, NONE, 1.1 .cvsignore, 1.1, 1.2 sources, 1.1, 1.2

[Ralf Corsepius]

On Thu, 2005-04-07 at 19:15 +0200, Ralf Ertzinger wrote:
> Hi.
> 
> Ralf Corsepius <rc040203 at freenet.de> wrote:
> 
> > The "/"'s after $(DESTDIR) are wrong. DESTDIR is supposed to be an
> > environment variable taking a directory prefix to "re-root" installs to
> > a different root.
> 
> Which is exactly what it is being used for here.
Not quite.

You are redirecting installations to $(DESTDIR)/ not to $(DESTDIR)

i.e., for example, a plain "make install" will install to 
//usr<something>
instead of
/usr<something>

> > (Note: "/" after DESTDIR in rpm specs are redundant, "/" after DESTDIR
> > in Makefiles are _bogus_ (== bug))
> 
> I'd like an explanation of that, but I think this is the wrong list.

I could write a length essay about it. Just to mention a few points:
* "make install DESTDIR=" should be free of side-effects
* Directories beginning with "//" are special on some OSes.
* The trailing slash is superfluous. All directories prefixed with
DESTDIR are known to be absolute.
..
Cf. to how automake handles DESTDIR.


The main difference between using "make DESTDIR=$(something)/" in an rpm
spec and using $(DESTDIR)/$(something) is:

* In a RH/Fedora rpm spec, the trailing slash is known not to cause harm
in most cases (In some cases it does).
* In a Makefile being used on several OSes it is very likely to cause
harm.

Ralf