rpms/perl-Spreadsheet-WriteExcel/devel perl-Spreadsheet-WriteExcel.spec, 1.1, 1.2

[José Pedro Oliveira]

Tom Callaway,

Several notes about the perl-Spreasheet-WriteExcel specfile
(most of them also apply to perl-OLE-Storage-Lite)

* the perl version in the build requirements should be
	perl >= 1:5.6.1
  (vendor dirs support)

* typo in the description

  < suggestions. This module cannot be uses to write to an existing
  ---
  > suggestions. This module cannot be used to write to an existing

* %build section

  for a noarch perl module the CFLAGS and the OPTIMIZE flags
  can be dropped; also the perl inline line can be dropped.

* %install section

  using "make pure_install" doesn't create the perllocal.pod file
  (the find perllocal.pod line can be dropped). Same thing for
  the find *.bs files as this is a noarch package

* %files section

  several documentation and example files missing

  %doc Changes README doc/ charts/

* DOS files

  As the several files are in DOS format (main script and
  documentation files), they should be converted to UNIX.

  Adding

  %{__perl} -pi -e 's/\r\n/\n/g' Changes README exe/chartex \
     doc/*.html charts/{README,*.{pl,pod,txt}}

  to the %prep section appears to fix them

* the defines in the top of the specfile aren't needed

* the source URL could be more explicit. Example

http://www.cpan.org/authors/id/J/JM/JMCNAMARA/Spreadsheet-WriteExcel-%{version}.tar.gz


Regards,
jpo
-- 
José Pedro Oliveira
* mailto: jpo at di.uminho.pt * http://gsd.di.uminho.pt/~jpo *
* gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 251 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/fedora-extras-commits/attachments/20050415/3866c883/attachment-0001.sig>