rpms/x3270/devel x3270-3.3-encoding.patch, NONE, 1.1 x3270.desktop, NONE, 1.1 x3270.spec, 1.2, 1.3

[Ignacio Vazquez-Abrams]

On Wed, 2005-04-20 at 06:53 -0400, Karsten Hopp wrote:
> Author: karsten
> 
> Update of /cvs/extras/rpms/x3270/devel
> In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv19796
> 
> Modified Files:
> 	x3270.spec 
> Added Files:
> 	x3270-3.3-encoding.patch x3270.desktop 
> Log Message:
> - spec file cleanups from Chris Ricker <kaboom at oobleck.net>
> - remove backup files from rpm patch process

> Index: x3270.spec

>  Prereq:  %{_prefix}/X11R6/bin/mkfontdir
>  BuildPreReq: ncurses-devel readline-devel glibc-devel

These should be "Requires(pre)" and "BuildRequires" respectively. And
you can drop the glibc-devel.

>  %package x11

>  Prereq: gtk2 >= 2.6

Should be "Requires(pre)".

> +%configure --prefix=%{_prefix}

Nope. %configure already sets --prefix, as well as a bunch of other
arguments.

> --- NEW FILE x3270.desktop ---
> [Desktop Entry]
> Name=x3270
> Type=Application
> Comment=3270 terminal emulator
> Exec=x3270
> Icon=x3270.png

>  desktop-file-install --vendor net \
> -        --dir $RPM_BUILD_ROOT/usr/share/applications \
> +        --dir $RPM_BUILD_ROOT/%{_datadir}/applications \
>          --add-category "Application;System;X-Red-Hat-Extra" \
>          $RPM_BUILD_ROOT%{_sysconfdir}/X11/applnk/Utilities/x3270.desktop

The vendor should be "fedora", and you should add "X-Fedora-Extra" as a
category. You also need to enable startup notification and add a
GenericName.
 
> +	mv $RPM_BUILD_ROOT/%{_prefix}/X11R6/bin/$i $RPM_BUILD_ROOT/%{_prefix}/bin

Nope. That last bit should become %{_bindir}.

-- 
Ignacio Vazquez-Abrams <ivazquez at ivazquez.net>
http://fedora.ivazquez.net/

gpg --keyserver hkp://subkeys.pgp.net --recv-key 38028b72
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-commits/attachments/20050420/666aa427/attachment-0001.sig>