rpms/epylog/devel epylog.spec, NONE, 1.1 .cvsignore, 1.1, 1.2 sources, 1.1, 1.2

Konstantin Ryabitsev mricon at gmail.com
Mon Apr 25 15:26:35 UTC 2005


On 4/23/05, Michael Schwendt <bugs.michael at gmx.net> wrote:
> > %{!?_perl_vendorlib: %define _perl_vendorlib %(eval "`perl -V:installvendorlib`"; echo $installvendorlib)}
> >
> 
> Without leading underscore, %perl_vendorlib and %perl_vendorarch (and
> more) come predefined for some longer time.

Yeah, but isn't it less consistent with all other directory macros,
such as %{_defaultdocdir} etc?

> > Version:        1.0.3
> > Release:        1
> > Epoch:          0
> 
> Epoch slipped in here by accident.

Not really. This RPM was first made when "everything must have an
Epoch specified even if it's 0" was the mantra among rpm-packagers.
The mantra has changed since then, but I didn't want to remove the
Epoch, since that could interfere with upgrading existing Epylog
installations.

> > %package perl
> > Summary:        Perl module for writing external Epylog modules
> > Group:          Development/Libraries
> > Requires:       epylog
> > Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
> >
> 
> Regardless of whether package update tools like Yum are used, sub-packages
> ought to "Requires: %name = %version-%release" to always be in sync with
> the main package.

Okay.

> > %install
> > rm -rf %{buildroot}
> > make install DESTDIR=%{buildroot}
> > ##
> > # Remove installed docs
> > #
> > rm -rf %{buildroot}%{_defaultdocdir}
> > ##
> > # Move docs to doc
> > #
> > mv AUTHORS ChangeLog INSTALL LICENSE README doc/
> 
> Moving these files breaks --short-circuit installs, better copy them.

Okay.

> > %dir %{_localstatedir}/lib/epylog
> > %dir %{_datadir}/epylog
> > %{_datadir}/epylog/modules/*
> 
> And "modules" directory is not included here.

Noted.

-- 
Konstantin Ryabitsev
Zlotniks, INC




More information about the fedora-extras-commits mailing list