rpms/MagicPoint/FC-4 MagicPoint.spec,1.1,1.2

[Colin Charles]

On Thu, 2005-08-04 at 16:29 +0200, Ralf Corsepius wrote:

> Did this spec file ever see a review?

Yes it did actually (on extras-list)
(and it was already a package in FC Core/Extras before, fwiw)

> > Index: MagicPoint.spec
> > ===================================================================
> > RCS file: /cvs/extras/rpms/MagicPoint/FC-4/MagicPoint.spec,v
> > retrieving revision 1.1
> > retrieving revision 1.2
> > diff -u -r1.1 -r1.2
> > --- MagicPoint.spec	27 Jun 2005 05:48:40 -0000	1.1
> > +++ MagicPoint.spec	4 Aug 2005 12:05:42 -0000	1.2
> 
> > +BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> > +BuildPrereq: freetype-devel
> BuildPrereq: is an anachronism. Please use BuildRequires, instead.

This has been in the spec file since before Extras entry (i.e. was in
Akira's Core package)

And if you start going to -extras-commits-list, this is not the first
example of said anachronism

FWIW, this is now changed to BuildRequires

> > +BuildRequires: fontconfig-devel xorg-x11-devel libungif-devel libpng-devel libmng-devel imlib-devel autoconf automake libtool byacc flex
> > +#Requires: VFlib2 >= 2.25.6-8 VFlib2-conf-ja >= 2.25.6-8
> > +Requires: imlib
> >  Obsoletes: mgp,magicpoint
> > +Provides: mgp,magicpoint
> >  
> >  %description
> >  MagicPoint is an X11 based presentation tool. MagicPoint's
> > @@ -37,13 +41,12 @@
> >  %patch6 -p1 -b .longline
> >  %patch10 -p1 -b .usleep
> >  %patch11 -p1 -b .gcc34
> > -%patch12 -p1 -b .undef-op
> >  
> >  %build
> >  CFLAGS=-I/usr/include/freetype1/freetype
> This should be CPPFLAGS, unless the configure script is really broken.

Again, also from the old spec; changed to CPPFLAGS

> >  autoconf
> >  cp /usr/share/libtool/config.{sub,guess} .
> Well, ... sometimes I feel sooo tired ... ;)

Uh huh, nothing changed here

> > -%configure --prefix=/usr/X11R6 --enable-gif
> > +%configure --prefix=/usr/X11R6 --enable-gif --disable-vflib --enable-imlib
> >  xmkmf -a
> >  make
> >  rm -rf $RPM_BUILD_DIR/magicpoint-%{version}/sample/.cvsignore
> > @@ -51,22 +54,24 @@
> >  %install
> >  [ -n "$RPM_BUILD_ROOT" -a "$RPM_BUILD_ROOT" != / ] &&
> This "test" is superfluous. It only makes some sense in spec files not
> containing a reasonable BuildRoot.

Again, from the older spec file; removed

> >  rm -rf $RPM_BUILD_ROOT
> >  make install install.man DESTDIR=$RPM_BUILD_ROOT
> > +strip `file $RPM_BUILD_ROOT/%{x11bindir}/* | grep ELF | cut -d : -f 1`
> This strip should be removed. It prevents debuginfo-rpms.

Debuginfo rpms have been created with it too, however removed

> >  %clean
> >  [ -n "$RPM_BUILD_ROOT" -a "$RPM_BUILD_ROOT" != / ] &&
> See above.

See above.

Thanks for being sharp
-- 
Colin Charles, http://www.bytebot.net/