devel/js js-va_copy.patch,NONE,1.1 js.spec,1.2,1.3

[Thorsten Leemhuis]

Am Montag, den 14.02.2005, 11:40 +0000 schrieb David Woodhouse:
> On Mon, 2005-02-14 at 07:44 +0100, Thorsten Leemhuis wrote:
> >
> >Well, I must say I have enough problems fixing x86_64 already ;-) This
> >was the only reason I touched js -- it's not my package...
> >
> >I found the patch I committed in a mandrake srpm. Their version was
> >(AFAICS) build for PPC also. So maybe you find something interesting
> >for PPC in their srpm, too:
> 
> The same patch fixes the PPC build -- it's just that you applied it only
> %ifarch x86_64. I've checked that the i386 build still works and taken
> out the %ifarch. 
> 
> In general, it's best to avoid %ifarch in specfiles as much as possible,
> especially for the application of patches. Life gets difficult if we end
> up with different sources on different platforms.

Well maybe I was a bit overcautious here... But I don't want to get know
as "thl -- that was the one who tried to to fix extras-x86_64 and broke
i386 while at it" ;-)
-- 
Thorsten Leemhuis <fedora at leemhuis.info>