rpms/nabi/devel nabi.spec,1.1,1.2

[Warren Togami]

Ralf Corsepius wrote:
> On Thu, 2005-03-17 at 02:54 -0500, Warren Togami wrote:
> 
>>Author: wtogami
> 
> 
>> 
>> %build
>>-./configure --prefix=%{prefix}
>>+./configure --prefix=/usr
> 
> 
>>+%attr(755,root,root)
>>+%{_bindir}/nabi
>>+%{_datadir}/nabi
>>+%{_datadir}/locale/*/LC_MESSAGES/nabi.mo
>>+%{_datadir}/applications/nabi.desktop
>> %{_sysconfdir}/X11/xinit/xinput.d
> 
> 
> ?? This is inconsistent:
> 
> * If you need "configure --prefix=/usr" you should hard code 
> /usr in %files, too.
> 
> * If you're using %{_XXX} in %files, you should pass each of the %{_XXX}
> vars to configure, too.
> 
> Try 
> rpmbuild --define '_prefix /usr/local' ...
> to see the effect of this inconsistency.
> 
> Ralf

Good catch.  Glad to see folks reviewing checkins.

Eternal vigilance.

Warren