devel/kphone kphone.spec,1.4,1.5

[Ralf Corsepius]

On Fri, 2005-03-18 at 16:41 -0500, Ignacio Vazquez-Abrams wrote:
> On Fri, 2005-03-18 at 22:32 +0100, Michael Schwendt wrote:
> > On Fri, 18 Mar 2005 16:19:44 -0500, Ignacio Vazquez-Abrams (ivazquez) wrote:
> > > Update of /cvs/extras/devel/kphone
> > 
> > > -%makeinstall
> > > +%makeinstall DESTDIR=$RPM_BUILD_ROOT
> > 
> > Sure about that?
Without any doubt this is wrong.

Either 
%makeinstall
or 
make DESTDIR=$RPM_BUILD_ROOT install
but not both.

In most cases you will want
make DESTDIR=$RPM_BUILD_ROOT install

>   The %makeinstall macro already prepends the buildroot
> > to all install locations like bindir, libdir, datadir and so on.
> 
> Unfortunately po/Makefile.in eschews mechanisms that allow that method
> to work. If anyone can come up with a patch then I'll be glad to
> incorporate it.

The kphone-4.1.0-po-hacks.diff I sent a couple of days ago, implements
this.

>  I'm still too new to autotools to handle it myself.
This package uses manually written Makefile.ins. The "make install"
related probs this package suffers from are Makefile bugs the authors of
this package are to blame for.


Try this patch:
--- kphone.spec 18 Mar 2005 21:19:42 -0000      1.5
+++ kphone.spec 19 Mar 2005 03:42:22 -0000
@@ -30,7 +30,8 @@

 %install
 rm -rf $RPM_BUILD_ROOT
-%makeinstall DESTDIR=$RPM_BUILD_ROOT
+make DESTDIR=$RPM_BUILD_ROOT install
+
 install -D -m 0644 icons/large-kphone.png $RPM_BUILD_ROOT%
{_datadir}/pixmaps/kphone.png
 desktop-file-install --vendor=Fedora \

Ralf