devel/hamlib hamlib-bindings.patch,1.1,1.2 hamlib.spec,1.7,1.8

[Michael Schwendt]

On Wed, 23 Mar 2005 18:28:07 -0500, Ignacio Vazquez-Abrams (ivazquez) wrote:

> Author: ivazquez
> 
> Update of /cvs/extras/devel/hamlib

>  -pythondir = $(prefix)/lib/python
> -+pythondir = $(prefix)/lib/python2.3
> ++pythondir = $(libdir)/python2.3

> +%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}

> +        pythondir=$RPM_BUILD_ROOT%{python_sitelib} \
>     install-pythonPYTHON

If you install into python sitelib (= /usr/lib/python...) and can set
pythondir= during make install, what do you need the hamlib-bindings.patch
for which defaults to /usr/lib64/python... on x86_64? If the patch is
needed, because the python bindings configuration needs it, it's
inconsistent.

>  %files python
>  %defattr(-, root, root)
> -%{_libdir}/python2.3/Hamlib.py
> -%{_libdir}/python2.3/Hamlib.pyc
> -%{_libdir}/python2.3/Hamlib.pyo
> +%{python_sitelib}/*.py*


The %_libdir/pkgconfig/hamlib.pc hardcodes libdir=${exec_prefix}/lib


In "hamlib" main package, /usr/lib/libhamlib-1.2.3.so.2.0.2 is included,
but the softlink /usr/lib/libhamlib-1.2.3.so.2 created by ldconfig is not:

  $ rpm -qf /usr/lib/libhamlib-1.2.3.so.2
  file /usr/lib/libhamlib-1.2.3.so.2 is not owned by any package

It's an upstream bug. Same for c++ sub-package.
You can fix this in packages with "ldconfig -N -n buildroot/somedir"
in %install section.


Licence COPYING included in %doc directory is GPL, but "License:" field
says LGPL. COPYING.LIB should be included instead.


%dir %{_includedir}/hamlib in -devel package is not included.


In the -devel package, all the %_libdir/hamlib-*.a static archives are
not needed. Their *.so counterparts in the main hamlib package are
loaded at run-time as backends by the frontend library libhamlib.
libhamlib provides the frontend user API.