rpms/mlmmj/devel mlmmj.spec, NONE, 1.1 .cvsignore, 1.1, 1.2 sources, 1.1, 1.2

[Michael Schwendt]

On Thu,  5 May 2005 06:44:50 -0400, Michael G. Fleming wrote:

> Author: mfleming
> 
> Update of /cvs/extras/rpms/mlmmj/devel

> --- NEW FILE mlmmj.spec ---
> %define _textlibdir /usr/share/mlmmj/text.skel
> 
> %define makeinstall  %{__make}  prefix=%{?buildroot:%{buildroot}}%{_prefix}  exec_prefix=%{?buildroot:%{buildroot}}%{_exec_prefix}  bindir=%{?buildroot:%{buildroot}}%{_bindir}  sbindir=%{?buildroot:%{buildroot}}%{_sbindir}  sysconfdir=%{?buildroot:%{buildroot}}%{_sysconfdir}  datadir=%{?buildroot:%{buildroot}}%{_datadir}  includedir=%{?buildroot:%{buildroot}}%{_includedir}  libdir=%{?buildroot:%{buildroot}}%{_libdir}  libexecdir=%{?buildroot:%{buildroot}}%{_libexecdir}  localstatedir=%{?buildroot:%{buildroot}}%{_localstatedir}  sharedstatedir=%{?buildroot:%{buildroot}}%{_sharedstatedir}  mandir=%{?buildroot:%{buildroot}}%{_mandir}  infodir=%{?buildroot:%{buildroot}}%{_infodir} textlibdir=%{?buildroot:%{buildroot}}%{_textlibdir} install
> 

Huh? Why that? %makeinstall comes predefined. Don't override globals like
this. In case you meant to append textlibdir=..., do that in %install like
this:

%makeinstall textlibdir=%{buildroot}%{_textlibdir}

> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> Requires: smtpdaemon
> URL: http://mlmmj.mmj.dk/
> 
> %description
> mlmmj (Mailing Lists Made Joyful) is a mailing list manager intended to mimic

Counting the 'm' characters, the long name in brackets doesn't match.
Made me think: "Mailing List Management Made Joyful" would fit. ;)
And indeed, the home page says: mailing list managing made joyful

> %build
> %configure
> 
> %install
> make %{?_smp_mflags}

No, wrong order here. Run make to compile the stuff in %build after
%configure.  And  rm -rf %{buildroot}  directly at the beginning of the
%install section to clean up your buildroot.