rpms/amaya/FC-3 .cvsignore, 1.2, 1.3 amaya.spec, 1.3, 1.4 sources, 1.2, 1.3

Ville Skyttä ville.skytta at iki.fi
Sun May 29 20:38:28 UTC 2005


On Sun, 2005-05-29 at 22:10 +0200, Ralf Corsepius wrote:
> On Sun, 2005-05-29 at 09:45 -0400, Aurelien Bompard wrote:
> > Author: abompard
> > 
> 
> > Index: amaya.spec
> 
> > @@ -30,16 +34,19 @@
> >  ../configure --enable-bookmarks \
> >               --prefix=$RPM_BUILD_ROOT%_libdir \
> >               --exec-prefix=$RPM_BUILD_ROOT/%_prefix \
> 
> Please think about what you are doing here - Passing RPM_BUILD_ROOT to
> configure scripts is wrong.

Also, the source tarball does not unpack into a single "Amaya" dir so
"%setup -q -n Amaya" is wrong, it does not instruct rpmbuild to clean up
properly: dirs libwww, Mesa, redland, and wxWidgets are left in the
build dir after build.

One way to fix that would be to use "%setup -q -c" and do "cd Amaya" at
start of each specfile section.




More information about the fedora-extras-commits mailing list