rpms/Terminal/devel Terminal.spec, NONE, 1.1 .cvsignore, 1.1, 1.2 sources, 1.1, 1.2

[Kevin Fenzi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Michael" == Michael Schwendt <bugs.michael at gmx.net> writes:

Michael> On Sat, 28 May 2005 06:55:43 +0200, Ralf Corsepius wrote:
>> On Sat, 2005-05-28 at 00:02 -0400, Kevin Fenzi wrote: > Author:
>> kevin
>> 
>> > Requires: vte >= 0.11.11 > Requires: exo >= 0.2.0 I doubt these
>> Requires are necessary, but haven't tried to investigate.

Michael> So, Kevin, please investigate. Since there is

Michael>   BuildRequires: vte-devel >= 0.11.11 BuildRequires:
Michael> exo-devel >= 0.3.0

Michael> already, it seems very likely that a dependency on
Michael> libvte.so.? and libexo.so.? will be automatic.

Correct. Removed those Requires. 

Michael> Explicit "Requires" should be avoided if they are
Michael> redundant. They make it more difficult to rename/move library
Michael> packages.

Agreed. 

Michael> The minimum versions in them get misleading or in accurate as
Michael> soon as they become out-of-date.  Look, for instance, you
Michael> buildrequire exo-devel >= 0.3.0, but you require exo >=
Michael> 0.2.0. That's a discrepancy already. Which version is true? 
Michael> The first exo package you imported into Extras CVS is 0.3.0,
Michael> so there is no older version anyway. The minimum version
Michael> could be dropped here.

Yes, it's 0.3.0 thats required by this version of terminal. The 0.2.0
is wrong and terminal won't compile against it. 
 
>> > %description > This is the Terminal emulator application.
>> 
>> I find this sentence to be a pretty bold exaggeration.
>> 
>> This package might be __a__ terminal emulator, but it definitely is
>> not __the__ terminal emulator.

Michael> Have read the followup to this already, but I
Michael> agree. Lower-case "This is a terminal emulator application"
Michael> would be better, since the name of the program "Terminal" is
Michael> too generic and need not be repeated in the description.

Agreed. That text was from the upstream spec. 
I think it would be best to remove that first sentence entirely. it's
confusing. Terminal is indeed pretty generic, and I wish they had
called it 'Xfce-terminal' or something upstream, but they didn't. ;( 

It really is a nice application tho... pretty much all the features of
gnome-terminal or konsole without all the overhead of gnome/kde. 

kevin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFCm12o3imCezTjY0ERAkjKAJwOq/Y3XuEQR08H8Zquqf30BTr40wCfR3J9
PCCxHKg2HWW6/J7Uxz54rJk=
=r9i0
-----END PGP SIGNATURE-----