rpms/octave/devel octave.spec,1.20,1.21

Quentin Spencer qspencer at ieee.org
Thu Oct 27 13:27:36 UTC 2005


Ralf Corsepius wrote:

>On Tue, 2005-10-25 at 11:19 -0400, Quentin Spencer wrote:
>  
>
>>Author: qspencer
>>    
>>
>
>  
>
>>Index: octave.spec
>>===================================================================
>>    
>>
>
>  
>
>>-Prereq:         /sbin/ldconfig
>>+Requires:       /sbin/ldconfig /sbin/install-info /etc/ld.so.conf.d
>>    
>>
>This is not correct.
>
>Your package uses /sbin/ldconfig and /sbin/install-info in
>%post,  /sbin/install-info in %preun, and /sbin/ldconfig in %postun:
>
>Therefore you can't avoid to add:
>
>Requires(post): /sbin/install-info
>Requires(postun): /sbin/ldconfig
>Requires(post): /sbin/ldconfig
>Requires(preun): /sbin/install-info
>  
>
I'll make this change. The previous change was just a consolidation of 
three existing dependencies into one line. All of the dependencies are 
as they were when I took over the package, other than that some used 
Prereq rather than Requires, which I understand now mean the same thing.

>Also, the dependency on the directory /etc/ld.so.conf.d is very
>questionable and arguable.
>
>If you really want to depend on the directory this should be
>Requires(pre): /etc/ld.so.conf.d
>and may-be even
>Requires(postun): /etc/ld.so.conf.d
>
>A plain "Requires: <dir>" doesn't have the effect you seem to want.
>  
>
This dependency was added by the maintainer at Red Hat before I took 
over the package, so I have no idea what the intended meaning was. I'm 
happy to just delete it.

-Quentin




More information about the fedora-extras-commits mailing list