rpms/octave/FC-4 octave-2.1.72-freqz.patch, NONE, 1.1 octave.spec, 1.23, 1.24

[Quentin Spencer (qspencer)]

Author: qspencer

Update of /cvs/extras/rpms/octave/FC-4
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv8386

Modified Files:
	octave.spec 
Added Files:
	octave-2.1.72-freqz.patch 
Log Message:
Fix bug #179242. The patch is taken from octave CVS, where it's already fixed.

octave-2.1.72-freqz.patch:

--- NEW FILE octave-2.1.72-freqz.patch ---
Index: scripts/signal/freqz.m
--- scripts/signal/freqz.m	2006-01-29 00:46:27.000000000 -0600
+++ scripts/signal/freqz.m	2006-01-29 00:53:57.000000000 -0600
@@ -84,7 +84,7 @@
     region = Fs = [];
   elseif (nargin == 4)
     Fs = [];
-    if (! isstr (region) && ! isempty (region))
+    if (! ischar (region) && ! isempty (region))
       Fs = region; 
       region = [];
     endif
@@ -114,26 +114,27 @@
     endif
   endif
 
-  a = a(:).';
-  b = b(:).';
+  a = a(:);
+  b = b(:);
 
   if (! isscalar (n)) ## Explicit frequency vector given
     w = f = n;
     if (nargin == 4)  ## Sampling rate Fs was specified
       w = 2*pi*f/Fs;
     endif
-    hb = polyval (fliplr(b), exp(-j*w));
-    ha = polyval (fliplr(a), exp(-j*w));
+    hb = polyval (fliplr(b), exp(j*w));
+    ha = polyval (fliplr(a), exp(j*w));
   elseif (strcmp (region, "whole"))
-    f = Fs * (0:n-1) / n;
-    ## polyval(fliplr(P),exp(-jw)) is O(p n) and fft(x) is O(n log(n)), where p is the 
-    ## order of the the polynomial P.  For small p it would be faster to use polyval  
-    ## but in practice the overhead for polyval is much higher and the little bit of
-    ## time saved isn't worth the extra code.
+    f = Fs * (0:n-1)' / n;
+    ## polyval(fliplr(P),exp(jw)) is O(p n) and fft(x) is O(n log(n)),
+    ## where p is the order of the the polynomial P.  For small p it
+    ## would be faster to use polyval but in practice the overhead for
+    ## polyval is much higher and the little bit of time saved isn't
+    ## worth the extra code.
     hb = fft (postpad (b, n));
     ha = fft (postpad (a, n));
   else
-    f = Fs/2 * (0:n-1) / n;
+    f = Fs/2 * (0:n-1)' / n;
     hb = fft (postpad (b, 2*n))(1:n);
     ha = fft (postpad (a, 2*n))(1:n);
   endif
@@ -169,9 +170,9 @@
 %!test # Sampling frequency properly interpreted
 %! b = [1 1 1]/3;
 %! [h,f] = freqz(b,1,16,320);
-%! assert(f,[0:15]*10,10*eps);
+%! assert(f,[0:15]'*10,10*eps);
 %! [h2,f2] = freqz(b,1,[0:15]*10,320);
 %! assert(f2,[0:15]*10,10*eps);
-%! assert(h,h2,20*eps);
+%! assert(h,h2',20*eps);
 %! [h3,f3] = freqz(b,1,32,'whole',320);
-%! assert(f3,[0:31]*10,10*eps);
+%! assert(f3,[0:31]'*10,10*eps);


Index: octave.spec
===================================================================
RCS file: /cvs/extras/rpms/octave/FC-4/octave.spec,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- octave.spec	26 Jan 2006 22:47:33 -0000	1.23
+++ octave.spec	29 Jan 2006 07:02:01 -0000	1.24
@@ -1,12 +1,13 @@
 Name:           octave
 Version:        2.1.72
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        A high-level language for numerical computations
 Epoch:          6
 
 Group:          Applications/Engineering
 License:        GPL
 Source:         ftp://ftp.octave.org/pub/octave/bleeding-edge/octave-%{version}.tar.bz2
+Patch0:         octave-2.1.72-freqz.patch
 URL:            http://www.octave.org
 Requires:       gnuplot less info texinfo 
 Requires(post): /sbin/install-info
@@ -48,6 +49,7 @@
 
 %prep
 %setup -q
+%patch0 -p0
 
 
 %build
@@ -118,6 +120,9 @@
 
 
 %changelog
+* Sat Jan 28 2006 Quentin Spencer <qspencer at users.sourceforge.net> 2.1.72-3
+- Patch to fix bug #179242.
+
 * Thu Jan 26 2006 Quentin Spencer <qspencer at users.sourceforge.net> 2.1.72-2
 - Rebuild for new release of hdf5.