upgradecheck upgradecheck.py,1.9,1.10

Ville Skytta (scop) fedora-extras-commits at redhat.com
Sun Jun 18 16:22:42 UTC 2006


Author: scop

Update of /cvs/fedora/upgradecheck
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv8504

Modified Files:
	upgradecheck.py 
Log Message:
Fix thinko in tracking the last seen version.  D'oh, more broken upgrade paths.


Index: upgradecheck.py
===================================================================
RCS file: /cvs/fedora/upgradecheck/upgradecheck.py,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- upgradecheck.py	18 Jun 2006 10:15:29 -0000	1.9
+++ upgradecheck.py	18 Jun 2006 16:22:40 -0000	1.10
@@ -155,17 +155,19 @@
         bork = None # index of first repo w/ problem
         ix = 0
         for curr in pkgdata:
-            if not curr:
-                # package missing from this repo
+            if not curr or not last:
+                # package missing from this repo or nothing to compare against
                 # TODO: detect holes in continuum
                 pass
-            elif last is None or name in known_good[enabled_dists[ix]]:
-                # first one seen or "known good" workaround
-                last = curr["evr"]
+            elif name in known_good[enabled_dists[ix]]:
+                # "known good" workaround -> skip compare
+                pass
             elif compareEVR(last, curr["evr"]) > 0:
                 # versioning problem
                 bork = ix - 1
                 break
+            if curr:
+                last = curr["evr"]
             ix = ix + 1
         if bork is not None:
             ix = bork




More information about the fedora-extras-commits mailing list