extras-buildsys/common Commands.py,1.5,1.6

Daniel Williams (dcbw) fedora-extras-commits at redhat.com
Tue May 9 19:10:59 UTC 2006


Author: dcbw

Update of /cvs/fedora/extras-buildsys/common
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv29423/common

Modified Files:
	Commands.py 
Log Message:
2006-05-09  Dan Williams  <dcbw at redhat.com>

    * builder/Builder.py
        - Handle the JobFiles request

    * common/Commands.py
        - Check arguments on PlgCommandJobFiles

    * server/ArchJob.py
        - pylint cleanups
        - Rework result files download code; archjob now requests result files
            from the builder, which knows how to handle builder-type specific
            result files operations
        - get_upload_dir() renamed to get_result_files_dir()

    * server/Builder.py
        - pylint cleanups
        - Move dispatching of common commands into the base Builder class
        - (_decompose_job_files_ack): new function; extract and return info
            from a JobFilesAck command
        - (_handle_job_files_ack): new function; handle a JobFilesAck in the
            builder-type specific manner.  For Active builders, we don't have
            to do much since the file was uploaded to us by the builder itself

    * server/BuilderManager.py
        - (any_prepping_builders): fix usage of builder.alive() -> builder.available()

    * server/PackageJob.py
        - Small cleanup of result files bits




Index: Commands.py
===================================================================
RCS file: /cvs/fedora/extras-buildsys/common/Commands.py,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- Commands.py	9 May 2006 02:53:03 -0000	1.5
+++ Commands.py	9 May 2006 19:10:56 -0000	1.6
@@ -567,6 +567,8 @@
         """The files argument is a python list of output files from the job"""
         PlgCommandAck.__init__(self, CMD_NAME_JOB_FILES_ACK, req_seq, seq)
         self._archjob_id = archjob_id
+        if type(files) is not type([]):
+            raise ValueError("files argument must be a list of URLs.")
         self._files = files
 
     def _deserialize(args):




More information about the fedora-extras-commits mailing list