rpms/wpa_supplicant/F-8 wpa_supplicant-0.5.7-fix-signal-leaks.patch, NONE, 1.1 wpa_supplicant.spec, 1.39, 1.40

[Daniel Williams (dcbw)]

Author: dcbw

Update of /cvs/extras/rpms/wpa_supplicant/F-8
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv17381

Modified Files:
	wpa_supplicant.spec 
Added Files:
	wpa_supplicant-0.5.7-fix-signal-leaks.patch 
Log Message:
* Thu Dec  6 2007 Dan Williams <dcbw at redhat.com> - 0.5.7-19
- Fix two leaks when signalling state and scan results (rh #408141)



wpa_supplicant-0.5.7-fix-signal-leaks.patch:

--- NEW FILE wpa_supplicant-0.5.7-fix-signal-leaks.patch ---
diff -up wpa_supplicant-0.5.7/ctrl_iface_dbus.c.signal-leak-fix wpa_supplicant-0.5.7/ctrl_iface_dbus.c
--- wpa_supplicant-0.5.7/ctrl_iface_dbus.c.signal-leak-fix	2007-12-06 18:10:22.000000000 -0500
+++ wpa_supplicant-0.5.7/ctrl_iface_dbus.c	2007-12-06 18:11:38.000000000 -0500
@@ -649,6 +649,7 @@ void wpa_supplicant_dbus_notify_scan_res
 		return;
 	}
 	dbus_connection_send(iface->con, signal, NULL);
+	dbus_message_unref (signal);
 }
 
 
@@ -666,7 +667,7 @@ void wpa_supplicant_dbus_notify_state_ch
 					     wpa_states old_state)
 {
 	struct ctrl_iface_dbus_priv *iface;
-	DBusMessage *signal;
+	DBusMessage *signal = NULL;
 	const char *path;
 	const char *new_state_str, *old_state_str;
 
@@ -711,7 +712,7 @@ void wpa_supplicant_dbus_notify_state_ch
 		wpa_printf(MSG_ERROR,
 		           "wpa_supplicant_dbus_notify_state_change[dbus]: "
 		           "couldn't convert state strings.");
-		return;
+		goto out;
 	}
 
 	if (!dbus_message_append_args(signal,
@@ -724,8 +725,13 @@ void wpa_supplicant_dbus_notify_state_ch
 		           "wpa_supplicant_dbus_notify_state_change[dbus]: "
 		           "not enough memory to construct state change "
 		           "signal.");
+		goto out;
 	}
+
 	dbus_connection_send(iface->con, signal, NULL);
+
+out:
+	dbus_message_unref (signal);
 }
 
 


Index: wpa_supplicant.spec
===================================================================
RCS file: /cvs/extras/rpms/wpa_supplicant/F-8/wpa_supplicant.spec,v
retrieving revision 1.39
retrieving revision 1.40
diff -u -r1.39 -r1.40
--- wpa_supplicant.spec	3 Dec 2007 19:03:45 -0000	1.39
+++ wpa_supplicant.spec	6 Dec 2007 23:26:43 -0000	1.40
@@ -2,7 +2,7 @@
 Name: wpa_supplicant
 Epoch: 1
 Version: 0.5.7
-Release: 18%{?dist}
+Release: 19%{?dist}
 License: BSD
 Group: System Environment/Base
 Source0: http://hostap.epitest.fi/releases/%{name}-%{version}.tar.gz
@@ -29,6 +29,7 @@
 Patch12: wpa_supplicant-0.5.7-ignore-dup-ca-cert-addition.patch
 Patch13: wpa_supplicant-0.5.7-fix-dynamic-wep-with-mac80211.patch
 Patch14: wpa_supplicant-0.5.7-use-IW_ENCODE_TEMP.patch
+Patch15: wpa_supplicant-0.5.7-fix-signal-leaks.patch
 URL: http://w1.fi/wpa_supplicant/
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
@@ -70,6 +71,7 @@
 %patch12 -p1 -b .ignore-dup-ca-cert-addition
 %patch13 -p1 -b .fix-dynamic-wep-with-mac80211
 %patch14 -p1 -b .use-IW_ENCODE_TEMP
+%patch15 -p1 -b .signal-leak-fixes
 
 %build
 cp %{SOURCE1} ./.config
@@ -158,6 +160,9 @@
 %{_bindir}/wpa_gui
 
 %changelog
+* Thu Dec  6 2007 Dan Williams <dcbw at redhat.com> - 0.5.7-19
+- Fix two leaks when signalling state and scan results (rh #408141)
+
 * Mon Dec  3 2007 Dan Williams <dcbw at redhat.com> - 0.5.7-18
 - Add logrotate config file (rh #404181)
 - Add new LSB initscript header to initscript with correct deps (rh #244029)