rpms/kernel/devel linux-2.6-net-bridge-rand-addr.patch, NONE, 1.1 kernel.spec, 1.300, 1.301

[Dave Jones (davej)]

Author: davej

Update of /cvs/pkgs/rpms/kernel/devel
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv1371

Modified Files:
	kernel.spec 
Added Files:
	linux-2.6-net-bridge-rand-addr.patch 
Log Message:
* Thu Dec 13 2007 Dave Jones <davej at redhat.com>
- bridge: assign random address.


linux-2.6-net-bridge-rand-addr.patch:

--- NEW FILE linux-2.6-net-bridge-rand-addr.patch ---
Assigning a valid random address to bridge device solves problems
when bridge device is brought up before adding real device to bridge.
When the first real device is added to the bridge, it's address
will overide the bridges random address.

Note: any device added to a bridge must already have a valid
ethernet address.
 br_add_if -> br_fdb_insert -> fdb_insert -> is_valid_ether_addr

Signed-off-by: Stephen Hemminger <shemminger at linux-foundation.org>

--- a/net/bridge/br_device.c	2007-10-16 16:48:21.000000000 -0700
+++ b/net/bridge/br_device.c	2007-12-11 15:36:52.000000000 -0800
@@ -157,8 +157,7 @@ static struct ethtool_ops br_ethtool_ops
 
 void br_dev_setup(struct net_device *dev)
 {
-	memset(dev->dev_addr, 0, ETH_ALEN);
-
+	random_ether_addr(dev->dev_addr);
 	ether_setup(dev);
 
 	dev->do_ioctl = br_dev_ioctl;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Index: kernel.spec
===================================================================
RCS file: /cvs/pkgs/rpms/kernel/devel/kernel.spec,v
retrieving revision 1.300
retrieving revision 1.301
diff -u -r1.300 -r1.301
--- kernel.spec	13 Dec 2007 15:12:58 -0000	1.300
+++ kernel.spec	13 Dec 2007 19:59:30 -0000	1.301
@@ -607,6 +607,7 @@
 Patch420: linux-2.6-squashfs.patch
 Patch423: linux-2.6-gfs-locking-exports.patch
 Patch430: linux-2.6-net-silence-noisy-printks.patch
+Patch431: linux-2.6-net-bridge-rand-addr.patch
 Patch440: linux-2.6-sha_alignment.patch
 Patch450: linux-2.6-input-kill-stupid-messages.patch
 Patch460: linux-2.6-serial-460800.patch
@@ -1087,6 +1088,8 @@
 # Networking
 # Disable easy to trigger printk's.
 ApplyPatch linux-2.6-net-silence-noisy-printks.patch
+# bridge: assign random address
+ApplyPatch linux-2.6-net-bridge-rand-addr.patch
 
 # Misc fixes
 # Fix SHA1 alignment problem on ia64
@@ -1741,6 +1744,9 @@
 %kernel_variant_files -a /%{image_install_path}/xen*-%{KVERREL} -e /etc/ld.so.conf.d/kernelcap-%{KVERREL}.conf %{with_xen} xen
 
 %changelog
+* Thu Dec 13 2007 Dave Jones <davej at redhat.com>
+- bridge: assign random address.
+
 * Thu Dec 13 2007 Kyle McMartin <kmcmartin at redhat.com>
 - 2.6.24-rc5-git3