[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: common cvs-import.sh,1.21,1.22

Jesse Keating さんは書きました:
So the easiest solution to me still seems to be to disable tagging and
make people run "make tag" by hand (oh! the effort;) and silence
Mailhot... ;-)

After catching up with some earlier threads on cvs-import.sh on fedora-maintainers list, I understand that he and others use purely cvs-import.sh to import package updates to cvs.

In his mail on 11th April:
| 1. cvs co + make srpm to get the current package state
| 2. expand the srpm in a clean root, modify it
| 3. rpmbuild -bs --nodeps
| 4. mock the result
| 5. test
| 6. cvs-import the mock-produced srpm changeset

So it is a bit of a hassle I guess to have to cvs update after importing and then tagging if he build directly with koji?

Might be best. I couldn't find it myself when looking through things, I think we're missing something subtle between cvs-import.sh and Makefile.common.

Actually it occurred to me why can't we just run "make tag" directly in cvs-import.sh in the temporary working checkout branch dir?

Would that not work?  Can someone test the patch below?

Index: cvs-import.sh
RCS file: /cvs/extras/common/cvs-import.sh,v
retrieving revision 1.23
diff -u -r1.23 cvs-import.sh
--- cvs-import.sh	21 May 2007 00:37:11 -0000	1.23
+++ cvs-import.sh	24 May 2007 00:28:22 -0000
@@ -313,7 +313,7 @@
 cvs -Q update && \
     echo "cvs commit..." && \
     cvs -Q commit ${MESSAGE:+-m "$MESSAGE"} && echo "Commit Complete" && \
-    cd ${BRANCH} && cvs -Q tag "${TAG}" && echo "Tagging '${TAG}' complete."
+    cd ${BRANCH} && make tag && echo "Tagging '${TAG}' complete."
 # Clean up

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]