rpms/kernel/devel linux-2.6-usb-storage-always-set-the-allow_restart-flag.patch, NONE, 1.1 kernel.spec, 1.256, 1.257

[Kyle McMartin (kyle)]

Author: kyle

Update of /cvs/pkgs/rpms/kernel/devel
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv29338

Modified Files:
	kernel.spec 
Added Files:
	linux-2.6-usb-storage-always-set-the-allow_restart-flag.patch 
Log Message:
* Tue Nov 27 2007 Kyle McMartin <kmcmartin at redhat.com>
- Some USB disks spin themselves down automatically and need
  scsi_device.allow_restart enabled so they'll spin back up.


linux-2.6-usb-storage-always-set-the-allow_restart-flag.patch:

--- NEW FILE linux-2.6-usb-storage-always-set-the-allow_restart-flag.patch ---
>From stern at rowland.harvard.edu Wed Oct 10 13:29:09 2007
From: Mauro Carvalho Chehab <mchehab at infradead.org>
Date: Wed, 10 Oct 2007 16:29:02 -0400 (EDT)
Subject: usb-storage: always set the allow_restart flag
To: Greg KH <greg at kroah.com>, Matthew Dharm <mdharm-usb at one-eyed-alien.net>
Cc: Mauro Carvalho Chehab <mchehab at infradead.org>,  USB Storage list <usb-storage at lists.one-eyed-alien.net>
Message-ID: <Pine.LNX.4.44L0.0710101627250.2739-100000 at iolanthe.rowland.org>


From: Mauro Carvalho Chehab <mchehab at infradead.org>

This patch (as1000) sets the SCSI allow_restart flag for USB disk
devices.  In theory this should never hurt, and there definitely are
devices out there (such as the Seagate 250-GB external drive) which
need the flag to be set.

Signed-off-by: Mauro Carvalho Chehab <mchehab at infradead.org>
Signed-off-by: Alan Stern <stern at rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>

---
 drivers/usb/storage/scsiglue.c |    4 ++++
 1 file changed, 4 insertions(+)

--- a/drivers/usb/storage/scsiglue.c
+++ b/drivers/usb/storage/scsiglue.c
@@ -177,6 +177,10 @@ static int slave_configure(struct scsi_d
 		 * is an occasional series of retries that will all fail. */
 		sdev->retry_hwerror = 1;
 
+		/* USB disks should allow restart.  Some drives spin down
+		 * automatically, requiring a START-STOP UNIT command. */
+		sdev->allow_restart = 1;
+
 	} else {
 
 		/* Non-disk-type devices don't need to blacklist any pages


Index: kernel.spec
===================================================================
RCS file: /cvs/pkgs/rpms/kernel/devel/kernel.spec,v
retrieving revision 1.256
retrieving revision 1.257
diff -u -r1.256 -r1.257
--- kernel.spec	27 Nov 2007 20:26:07 -0000	1.256
+++ kernel.spec	28 Nov 2007 00:51:40 -0000	1.257
@@ -631,6 +631,8 @@
 Patch1530: linux-2.6-fix-kd.h.patch
 Patch1540: linux-2.6-fec_mpc52xx-fix.patch
 
+Patch1600: linux-2.6-usb-storage-always-set-the-allow_restart-flag.patch
+
 # drm-mm catchup (modesetting, ...)
 Patch1801: linux-2.6-drm-mm.patch
 Patch1800: linux-2.6-agp-mm.patch
@@ -1144,6 +1146,9 @@
 # Fix fec_mpc52xx not to corrupt memory
 ApplyPatch linux-2.6-fec_mpc52xx-fix.patch
 
+# some usb disks spin down automatically and need allow_restart
+ApplyPatch linux-2.6-usb-storage-always-set-the-allow_restart-flag.patch
+
 ApplyPatch linux-2.6-e1000-corrupt-eeprom-checksum.patch
 
 # drm-mm catchup (modesetting, ...)
@@ -1709,6 +1714,10 @@
 %kernel_variant_files -a /%{image_install_path}/xen*-%{KVERREL} -e /etc/ld.so.conf.d/kernelcap-%{KVERREL}.conf %{with_xen} xen
 
 %changelog
+* Tue Nov 27 2007 Kyle McMartin <kmcmartin at redhat.com>
+- Some USB disks spin themselves down automatically and need
+  scsi_device.allow_restart enabled so they'll spin back up.
+
 * Tue Nov 27 2007 John W. Linville <linville at redhat.com>
 * Fix NULL ptr reference in iwlwifi (CVE-2007-5938)