rpms/kernel-xen-2.6/F-7 linux-2.6-cve-2008-0600.patch, NONE, 1.1 kernel.spec, 1.7, 1.8

[Eduardo Habkost (ehabkost)]

Author: ehabkost

Update of /cvs/pkgs/rpms/kernel-xen-2.6/F-7
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv9805

Modified Files:
	kernel.spec 
Added Files:
	linux-2.6-cve-2008-0600.patch 
Log Message:
CVE-2008-0600 fix (bug #432517)


linux-2.6-cve-2008-0600.patch:

--- NEW FILE linux-2.6-cve-2008-0600.patch ---
From: Bastian Blank <bastian at waldi.eu.org>
Date: Sun, 10 Feb 2008 14:47:57 +0000 (+0200)
Subject: splice: fix user pointer access in get_iovec_page_array()
X-Git-Url: http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git;a=commitdiff_plain;h=712a30e63c8066ed84385b12edbfb804f49cbc44

splice: fix user pointer access in get_iovec_page_array()

Commit 8811930dc74a503415b35c4a79d14fb0b408a361 ("splice: missing user
pointer access verification") added the proper access_ok() calls to
copy_from_user_mmap_sem() which ensures we can copy the struct iovecs
from userspace to the kernel.

But we also must check whether we can access the actual memory region
pointed to by the struct iovec to fix the access checks properly.

Signed-off-by: Bastian Blank <waldi at debian.org>
Acked-by: Oliver Pinter <oliver.pntr at gmail.com>
Cc: Jens Axboe <jens.axboe at oracle.com>
Cc: Andrew Morton <akpm at linux-foundation.org>
Signed-off-by: Pekka Enberg <penberg at cs.helsinki.fi>
Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
---

diff --git a/fs/splice.c b/fs/splice.c
index 14e2262..9b559ee 100644
--- a/fs/splice.c
+++ b/fs/splice.c
@@ -1234,7 +1234,7 @@ static int get_iovec_page_array(const struct iovec __user *iov,
 		if (unlikely(!len))
 			break;
 		error = -EFAULT;
-		if (unlikely(!base))
+		if (!access_ok(VERIFY_READ, base, len))
 			break;
 
 		/*



Index: kernel.spec
===================================================================
RCS file: /cvs/pkgs/rpms/kernel-xen-2.6/F-7/kernel.spec,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- kernel.spec	19 Nov 2007 11:48:06 -0000	1.7
+++ kernel.spec	12 Feb 2008 17:15:51 -0000	1.8
@@ -918,6 +918,12 @@
 Patch5000: linux-2.6-firewire.patch
 Patch5001: linux-2.6-firewire-be32-fix.patch
 
+# Security:
+
+# CVE-2008-0600 (bug #432517)
+Patch6000: linux-2.6-cve-2008-0600.patch
+
+
 #
 # 10000 to 20000 is for stuff that has to come last due to the
 # amount of drivers they touch. But only these should go here.
@@ -1681,6 +1687,10 @@
 %patch5000 -p1
 %patch5001 -p1
 
+# security:
+%patch6000 -p1
+
+
 #
 # final stuff
 #
@@ -2266,6 +2276,9 @@
 %kernel_variant_files -a /%{image_install_path}/xen*-%{KVERREL} -e /etc/ld.so.conf.d/kernelcap-%{KVERREL}.conf %{with_xen} xen
 
 %changelog
+* Tue Feb 12 2008 Eduardo Habkost <ehabkost at redhat.com>
+- CVE-2008-0600 fix (bug #432517)
+
 * Mon Nov 19 2007 Eduardo Habkost <ehabkost at redhat.com>
 - Re-add xen-hypervisor-abi provides. It was lost on the spec resync
   (problem detected on updates-testing)