rpms/mysql/devel mysql-stack.patch,1.3,1.4 mysql.spec,1.100,1.101

Tom Lane (tgl) fedora-extras-commits at redhat.com
Tue Jan 8 05:41:38 UTC 2008


Author: tgl

Update of /cvs/pkgs/rpms/mysql/devel
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv21598

Modified Files:
	mysql-stack.patch mysql.spec 
Log Message:
Sigh ... this code is even more fragile than it appears.  Try setting
STACK_MIN_SIZE to 24K, not either 16K nor 32K, each of which fail for
different reasons.

mysql-stack.patch:

Index: mysql-stack.patch
===================================================================
RCS file: /cvs/pkgs/rpms/mysql/devel/mysql-stack.patch,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- mysql-stack.patch	8 Jan 2008 04:47:12 -0000	1.3
+++ mysql-stack.patch	8 Jan 2008 05:41:31 -0000	1.4
@@ -2,7 +2,9 @@
 and probably not on some other platforms either.  Knock it up to twice the
 pre-5.0.33 value to have some margin for future changes in compiler, glibc,
 etc.  Suspect this number if "execution_constants" regression test fails.
-As of 5.0.45 and F9, it seems 16384 isn't enough either.
+
+As of 5.0.45 and F9, it seems 16384 isn't enough anymore (ppc fails);
+while 32768 is too much as it makes other regression tests fail.
 
 
 diff -Naur mysql-5.0.38.orig/sql/mysql_priv.h mysql-5.0.38/sql/mysql_priv.h
@@ -13,7 +15,7 @@
   "execution_constants" test to pass.
   */
 -#define STACK_MIN_SIZE          12000   // Abort if less stack during eval.
-+#define STACK_MIN_SIZE          32768   // Abort if less stack during eval.
++#define STACK_MIN_SIZE          24576   // Abort if less stack during eval.
  
  #define STACK_MIN_SIZE_FOR_OPEN 1024*80
  #define STACK_BUFF_ALLOC	256	// For stack overrun checks


Index: mysql.spec
===================================================================
RCS file: /cvs/pkgs/rpms/mysql/devel/mysql.spec,v
retrieving revision 1.100
retrieving revision 1.101
diff -u -r1.100 -r1.101
--- mysql.spec	8 Jan 2008 04:47:12 -0000	1.100
+++ mysql.spec	8 Jan 2008 05:41:31 -0000	1.101
@@ -482,7 +482,7 @@
 %{_mandir}/man1/mysql_client_test.1*
 
 %changelog
-* Mon Jan  7 2008 Tom Lane <tgl at redhat.com> 5.0.45-7
+* Tue Jan  8 2008 Tom Lane <tgl at redhat.com> 5.0.45-7
 - Unbelievable ... upstream still thinks that it's a good idea to have a
   regression test that is guaranteed to begin failing come January 1.
 - ... and it seems we need to raise STACK_MIN_SIZE again too.




More information about the fedora-extras-commits mailing list