rpms/elinks/devel elinks-0.12pre1-tabreload.patch, NONE, 1.1 elinks.spec, 1.54, 1.55

Ondrej Vasik (ovasik) fedora-extras-commits at redhat.com
Tue Jul 15 08:52:33 UTC 2008


Author: ovasik

Update of /cvs/extras/rpms/elinks/devel
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv25878

Modified Files:
	elinks.spec 
Added Files:
	elinks-0.12pre1-tabreload.patch 
Log Message:
upstream fix of crash when opening new tab while reloading page

elinks-0.12pre1-tabreload.patch:

--- NEW FILE elinks-0.12pre1-tabreload.patch ---
Fix crash after a tab was opened during reload.

---
commit b07fecc2be6eeb7e20e555f6128e50f1ed4ee7f9
tree 5df3f87ddb3ed9bae1126009cd755f7137c89cf6
parent 6b05cdb3a0a12e8cf8bae3860b1a59e86d3076a1
author Kalle Olavi Niemitalo <kon at iki.fi> Tue, 15 Jul 2008 00:09:27 +0300
committer Kalle Olavi Niemitalo <Kalle at Astalo.kon.iki.fi> Tue, 15 Jul 2008 00:09:27 +0300

 NEWS                 |    2 ++
 src/viewer/text/vs.c |    6 ++++++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/NEWS b/NEWS
index b01a90a..7108a8e 100644
--- a/NEWS
+++ b/NEWS
@@ -44,6 +44,8 @@
 
 Miscellaneous:
 
+* critical: Fix crash after a tab was opened during reload.  This was
+  triggered by the bug 620 fix in ELinks 0.12pre1.
 * critical bug 723: fix dangling pointer crash when following a link
   in a frame
 * critical bug 756: ``assertion (cached)->object.refcount >= 0 failed''
diff --git a/src/viewer/text/vs.c b/src/viewer/text/vs.c
index d0bbdf5..a7978db 100644
--- a/src/viewer/text/vs.c
+++ b/src/viewer/text/vs.c
@@ -79,6 +79,12 @@ copy_vs(struct view_state *dst, struct view_state *src)
 	dst->ecmascript_fragile = 1;
 #endif
 
+	/* destroy_vs(vs) does mem_free_if(vs->form_info), so each
+	 * view_state must have its own form_info.  Normally we make a
+	 * copy below, but not if src->form_info_len is 0, which it
+	 * can be even if src->form_info is not NULL.  */
+	dst->form_info = NULL;
+
 	/* Clean as a baby. */
 	dst->doc_view = NULL;


Index: elinks.spec
===================================================================
RCS file: /cvs/extras/rpms/elinks/devel/elinks.spec,v
retrieving revision 1.54
retrieving revision 1.55
diff -u -r1.54 -r1.55
--- elinks.spec	2 Jul 2008 08:48:38 -0000	1.54
+++ elinks.spec	15 Jul 2008 08:51:44 -0000	1.55
@@ -1,7 +1,7 @@
 Name:      elinks
 Summary:   A text-mode Web browser
 Version:   0.12
-Release:   0.1.pre1%{?dist}
+Release:   0.2.pre1%{?dist}
 License:   GPLv2
 URL:       http://elinks.or.cz
 Group:     Applications/Internet
@@ -28,6 +28,7 @@
 Patch5: elinks-0.10.1-xterm.patch
 Patch6: elinks-0.11.0-union.patch
 Patch7: elinks-0.11.3-macropen.patch
+Patch8: elinks-0.12pre1-tabreload.patch
 
 %description
 Links is a text-based Web browser. Links does not display any images,
@@ -53,6 +54,8 @@
 %patch6 -p1
 # fix for open macro in new glibc 
 %patch7 -p1
+# upstream fix for opening tab during reload
+%patch8 -p1
 
 %build
 ./autogen.sh
@@ -83,6 +86,9 @@
 %{_mandir}/man5/*
 
 %changelog
+* Tue Jul 15 2008 Ondrej Vasik <ovasik at redhat.com> 0.12-0.2.pre1
+- fix a crash when opening tab during page reload
+
 * Tue Jul  1 2008 Ondrej Vasik <ovasik at redhat.com> 0.12-0.1.pre1
 - unstable elinks-0.12 pre1, solves several long-term issues 
   unsolvable (or very hard to solve) in 0.11.4 (like #173411),




More information about the fedora-extras-commits mailing list