rpms/PackageKit/devel pk-cleanup-transaction-longer.patch, NONE, 1.1 PackageKit.spec, 1.81, 1.82

[Richard Hughes]

Author: rhughes

Update of /cvs/pkgs/rpms/PackageKit/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv3115

Modified Files:
	PackageKit.spec 
Added Files:
	pk-cleanup-transaction-longer.patch 
Log Message:
* Wed Nov 05 2008 Richard Hughes  <rhughes at redhat.com> - 0.3.9-4
- Increase the timeout for cleaning up unused transactions. Due to a bug
  in the PkClient library the new TID was not being requested, and the old
  TID was being re-used. This gave a DBUS error if the user spent longer than
  five seconds entering the password the very first time they used PackageKit
  to do an authentication.
  Apply a simple patch to mitigate this, as a more invasive (and correct)
  patch is upstream. A new release will follow in f10-updates. Fixes rh#469950


pk-cleanup-transaction-longer.patch:

--- NEW FILE pk-cleanup-transaction-longer.patch ---
diff --git a/src/pk-transaction-list.c b/src/pk-transaction-list.c
index 2e5a018..ad9aedd 100644
--- a/src/pk-transaction-list.c
+++ b/src/pk-transaction-list.c
@@ -56,7 +56,7 @@ static void     pk_transaction_list_finalize	(GObject        *object);
 #define PK_TRANSACTION_LIST_KEEP_FINISHED_TIMEOUT	5
 
 /* how long the tid is valid before it's destroyed, in seconds */
-#define PK_TRANSACTION_LIST_CREATE_COMMIT_TIMEOUT	5
+#define PK_TRANSACTION_LIST_CREATE_COMMIT_TIMEOUT	5000
 
 /* the interval between each CST, in seconds */
 #define PK_TRANSACTION_WEDGE_CHECK			10


Index: PackageKit.spec
===================================================================
RCS file: /cvs/pkgs/rpms/PackageKit/devel/PackageKit.spec,v
retrieving revision 1.81
retrieving revision 1.82
diff -u -r1.81 -r1.82
--- PackageKit.spec	30 Oct 2008 16:32:17 -0000	1.81
+++ PackageKit.spec	5 Nov 2008 09:54:59 -0000	1.82
@@ -8,7 +8,7 @@
 Summary:   System daemon that is a DBUS abstraction layer for package management
 Name:      PackageKit
 Version:   0.3.9
-Release:   3%{?dist}
+Release:   4%{?dist}
 License:   GPLv2+
 Group:     System Environment/Libraries
 URL:       http://packagekit.freedesktop.org
@@ -31,6 +31,9 @@
 # upstream, 32f39d67971f1bd6dbf4b559a8f95e8712edccf8
 Patch4:    pk-fix-get-distro-upgrade.patch
 
+# upstream, with the proper fix not this bodge
+Patch5:    pk-cleanup-transaction-longer.patch
+
 Requires: dbus >= %{dbus_version}
 Requires: dbus-glib >= %{dbus_glib_version}
 Requires: PackageKit-glib = %{version}-%{release}
@@ -216,6 +219,7 @@
 %patch2 -p1
 %patch3 -p1
 %patch4 -p1
+%patch5 -p1
 
 %build
 %configure --enable-yum --enable-smart --with-default-backend=yum --disable-local
@@ -389,6 +393,15 @@
 %{_includedir}/PackageKit/backend/*.h
 
 %changelog
+* Wed Nov 05 2008 Richard Hughes  <rhughes at redhat.com> - 0.3.9-4
+- Increase the timeout for cleaning up unused transactions. Due to a bug
+  in the PkClient library the new TID was not being requested, and the old
+  TID was being re-used. This gave a DBUS error if the user spent longer than
+  five seconds entering the password the very first time they used PackageKit
+  to do an authentication.
+  Apply a simple patch to mitigate this, as a more invasive (and correct)
+  patch is upstream. A new release will follow in f10-updates. Fixes rh#469950
+
 * Thu Oct 28 2008 Richard Hughes  <rhughes at redhat.com> - 0.3.9-3
 - Install the usr/share/cmake/Modules/FindQPackageKit.cmake file so we
   can build KPackageKit from svn head.