rpms/gnome-session/devel empty-string-leak.patch, NONE, 1.1 gnome-session.spec, 1.190, 1.191

[Matthias Clasen]

Author: mclasen

Update of /cvs/extras/rpms/gnome-session/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv5426

Modified Files:
	gnome-session.spec 
Added Files:
	empty-string-leak.patch 
Log Message:
plug memory leaks


empty-string-leak.patch:

--- NEW FILE empty-string-leak.patch ---
diff -up gnome-session-2.23.92/gnome-session/gsm-manager.c.empty-string-leak gnome-session-2.23.92/gnome-session/gsm-manager.c
--- gnome-session-2.23.92/gnome-session/gsm-manager.c.empty-string-leak	2008-09-14 21:44:18.000000000 -0400
+++ gnome-session-2.23.92/gnome-session/gsm-manager.c	2008-09-14 21:48:06.000000000 -0400
@@ -913,6 +913,7 @@ _on_query_end_session_timeout (GsmManage
                 app_id = g_strdup (gsm_client_peek_app_id (l->data));
                 if (IS_STRING_EMPTY (app_id)) {
                         /* XSMP clients don't give us an app id unless we start them */
+                        g_free (app_id);
                         app_id = gsm_client_get_app_name (l->data);
                 }
 
@@ -1529,6 +1530,7 @@ on_client_end_session_response (GsmClien
                 app_id = g_strdup (gsm_client_peek_app_id (client));
                 if (IS_STRING_EMPTY (app_id)) {
                         /* XSMP clients don't give us an app id unless we start them */
+                        g_free (app_id);
                         app_id = gsm_client_get_app_name (client);
                 }
 


Index: gnome-session.spec
===================================================================
RCS file: /cvs/extras/rpms/gnome-session/devel/gnome-session.spec,v
retrieving revision 1.190
retrieving revision 1.191
diff -u -r1.190 -r1.191
--- gnome-session.spec	15 Sep 2008 00:25:40 -0000	1.190
+++ gnome-session.spec	15 Sep 2008 01:50:49 -0000	1.191
@@ -12,7 +12,7 @@
 Summary: GNOME session manager
 Name: gnome-session
 Version: 2.23.92
-Release: 2%{?dist}
+Release: 3%{?dist}
 URL: http://www.gnome.org
 Source0: http://download.gnome.org/sources/gnome-session/2.23/%{name}-%{version}.tar.bz2
 Source1: redhat-default-session
@@ -69,6 +69,8 @@
 Patch1: previous_id-leak.patch
 # http://bugzilla.gnome.org/show_bug.cgi?id=552294
 Patch2: inhibitor-leak.patch
+# http://bugzilla.gnome.org/show_bug.cgi?id=552302
+Patch3: empty-string-leak.patch
 
 %description
 
@@ -80,6 +82,7 @@
 %patch0 -p1 -b .ListenObjs-leak
 %patch1 -p1 -b .previous_id-leak
 %patch2 -p1 -b .inhibitor-leak
+%patch3 -p1 -b .empty-string-leak
 
 %build
 
@@ -178,6 +181,9 @@
 
 
 %changelog
+* Sun Sep 14 2008 Matthias Clasen  <mclasen at redhat.com> - 2.23.92-3
+- Plug memory leaks
+
 * Sun Sep 14 2008 Matthias Clasen  <mclasen at redhat.com> - 2.23.92-2
 - Plug memory leaks