rpms/libxcb/F-10 libxcb-1.1.91-xidgen.patch, NONE, 1.1 libxcb.spec, 1.12, 1.13

[Christopher Aillon]

Author: caillon

Update of /cvs/extras/rpms/libxcb/F-10
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv11945

Modified Files:
	libxcb.spec 
Added Files:
	libxcb-1.1.91-xidgen.patch 
Log Message:
* Tue Apr 21 2009 Christopher Aillon <caillon at redhat.com> 1.1.91-6
- Add upstream fix for XID generation


libxcb-1.1.91-xidgen.patch:

--- NEW FILE libxcb-1.1.91-xidgen.patch ---
>From beccb0be15f5699c942a0af33307d9e4bf797e2a Mon Sep 17 00:00:00 2001
From: Bart Massey <bart at cs.pdx.edu>
Date: Tue, 24 Mar 2009 23:24:04 +0000
Subject: kludgily hand-merged xid fixes

Signed-off-by: Bart Massey <bart at cs.pdx.edu>
Signed-off-by: Julien Danjou <julien at danjou.info>
---
diff --git a/src/xcb_xid.c b/src/xcb_xid.c
index 7ff0c5f..3df5dbe 100644
--- a/src/xcb_xid.c
+++ b/src/xcb_xid.c
@@ -1,4 +1,4 @@
-/* Copyright (C) 2001-2004 Bart Massey and Jamey Sharp.
+/* Copyright (C) 2001-2008 Bart Massey and Jamey Sharp.
  *
  * Permission is hereby granted, free of charge, to any person obtaining a
  * copy of this software and associated documentation files (the "Software"),
@@ -25,6 +25,7 @@
 
 /* XID allocators. */
 
+#include <assert.h>
 #include <stdlib.h>
 #include "xcb.h"
 #include "xcbext.h"
@@ -39,21 +40,40 @@ uint32_t xcb_generate_id(xcb_connection_t *c)
     if(c->has_error)
         return -1;
     pthread_mutex_lock(&c->xid.lock);
-    if(c->xid.last == c->xid.max)
+    if(c->xid.last >= c->xid.max - c->xid.inc + 1)
     {
         xcb_xc_misc_get_xid_range_reply_t *range;
-        range = xcb_xc_misc_get_xid_range_reply(c, xcb_xc_misc_get_xid_range(c), 0);
-        if(!range)
-        {
-            pthread_mutex_unlock(&c->xid.lock);
-            return -1;
+        assert(c->xid.last == c->xid.max);
+        if (c->xid.last == 0) {
+            /* finish setting up initial range */
+            c->xid.max = c->setup->resource_id_mask;
+        } else {
+            /* check for extension */
+            const xcb_query_extension_reply_t *xc_misc_reply =
+              xcb_get_extension_data(c, &xcb_xc_misc_id);
+            if (!xc_misc_reply) {
+                pthread_mutex_unlock(&c->xid.lock);
+                return -1;
+            }
+            /* get new range */
+            range = xcb_xc_misc_get_xid_range_reply(c,
+                      xcb_xc_misc_get_xid_range(c), 0);
+            /* XXX The latter disjunct is what the server returns
+               when it is out of XIDs.  Sweet. */
+            if(!range || (range->start_id == 0 && range->count == 1))
+            {
+                pthread_mutex_unlock(&c->xid.lock);
+                return -1;
+            }
+            assert(range->count > 0 && range->start_id > 0);
+            c->xid.last = range->start_id;
+            c->xid.max = range->start_id + (range->count - 1) * c->xid.inc;
+            free(range);
         }
-        c->xid.last = range->start_id;
-        c->xid.max = range->start_id + (range->count - 1) * c->xid.inc;
-        free(range);
+    } else {
+        c->xid.last += c->xid.inc;
     }
     ret = c->xid.last | c->xid.base;
-    c->xid.last += c->xid.inc;
     pthread_mutex_unlock(&c->xid.lock);
     return ret;
 }
@@ -65,8 +85,8 @@ int _xcb_xid_init(xcb_connection_t *c)
     if(pthread_mutex_init(&c->xid.lock, 0))
         return 0;
     c->xid.last = 0;
+    c->xid.max = 0;
     c->xid.base = c->setup->resource_id_base;
-    c->xid.max = c->setup->resource_id_mask;
     c->xid.inc = c->setup->resource_id_mask & -(c->setup->resource_id_mask);
     return 1;
 }
--
cgit v0.8.2



Index: libxcb.spec
===================================================================
RCS file: /cvs/extras/rpms/libxcb/F-10/libxcb.spec,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- libxcb.spec	19 Oct 2008 23:10:39 -0000	1.12
+++ libxcb.spec	21 Apr 2009 18:21:00 -0000	1.13
@@ -1,6 +1,6 @@
 Name:           libxcb
 Version:        1.1.91
-Release:        5%{?dist}
+Release:        6%{?dist}
 Summary:        A C binding to the X11 protocol
 
 Group:          System Environment/Libraries
@@ -17,6 +17,7 @@
 Patch0:         libxcb-1.1-no-pthread-stubs.patch
 Patch2:		libxcb-1.1-sloppy-lock.patch
 Patch3:		libxcb-1.1.91-git.patch
+Patch4:         libxcb-1.1.91-xidgen.patch
 
 BuildRequires:  autoconf automake libtool pkgconfig
 BuildRequires:  doxygen
@@ -55,6 +56,7 @@
 %patch0 -p1 -b .pthread-stubs
 %patch2 -p1 -b .sloppier
 %patch3 -p1 -b .git
+%patch4 -p1 -b .xidgen
 
 %build
 autoreconf -v --install
@@ -90,6 +92,9 @@
 %{_datadir}/doc/%{name}-%{version}
 
 %changelog
+* Tue Apr 21 2009 Christopher Aillon <caillon at redhat.com> 1.1.91-6
+- Add upstream fix for XID generation
+
 * Sun Oct 19 2008 Adam Jackson <ajax at redhat.com> 1.1.91-5
 - Add pthread-stubs.pc