rpms/openoffice.org/devel openoffice.org-3.0.1.ooo99081.vcl.dont.release.before-reuse.patch, NONE, 1.1 openoffice.org.spec, 1.1788, 1.1789
Caolan McNamara
caolanm at fedoraproject.org
Tue Feb 10 17:09:31 UTC 2009
- Previous message (by thread): rpms/valgrind/devel valgrind-3.4.0-debug.patch, NONE, 1.1 valgrind-3.4.0-newbu.patch, NONE, 1.1 valgrind-3.4.0-cachegrind-improvements.patch, 1.1, 1.2 valgrind-3.4.0-power5+-6.patch, 1.1, 1.2 valgrind.spec, 1.59, 1.60
- Next message (by thread): rpms/openoffice.org/F-10 openoffice.org-3.0.1.ooo99081.vcl.dont.release.before-reuse.patch, NONE, 1.1 openoffice.org.spec, 1.1716, 1.1717
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Author: caolanm
Update of /cvs/pkgs/rpms/openoffice.org/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv19998/devel
Modified Files:
openoffice.org.spec
Added Files:
openoffice.org-3.0.1.ooo99081.vcl.dont.release.before-reuse.patch
Log Message:
Resolves: rhbz#484604 crash in glyph substitution
openoffice.org-3.0.1.ooo99081.vcl.dont.release.before-reuse.patch:
--- NEW FILE openoffice.org-3.0.1.ooo99081.vcl.dont.release.before-reuse.patch ---
Index: outdev3.cxx
===================================================================
RCS file: /cvs/gsl/vcl/source/gdi/outdev3.cxx,v
retrieving revision 1.242.2.2
diff -u -r1.242.2.2 outdev3.cxx
--- openoffice.org.orig/vcl/source/gdi/outdev3.cxx 11 Dec 2008 17:11:54 -0000 1.242.2.2
+++ openoffice.org/vcl/source/gdi/outdev3.cxx 10 Feb 2009 16:53:04 -0000
@@ -6272,25 +6272,32 @@
if( mpOutDevData && !mpOutDevData->maDevFontSubst.Empty() )
nDevSpecificFallback = 1;
+ ImplFontEntry* pLastFallbackFont = NULL;
+
// try if fallback fonts support the missing unicodes
for( int nFallbackLevel = 1; nFallbackLevel < MAX_FALLBACK; ++nFallbackLevel )
{
// find a font family suited for glyph fallback
ImplFontEntry* pFallbackFont = mpFontCache->GetGlyphFallbackFont( mpFontList,
aFontSelData, nFallbackLevel-nDevSpecificFallback, aMissingCodes );
+
+ if (pLastFallbackFont)
+ mpFontCache->Release( pLastFallbackFont );
+ pLastFallbackFont = pFallbackFont;
+
if( !pFallbackFont )
break;
+ //aFontSelData.mpFontEntry will be used by next GetGlyphFallbackFont so
+ //we must not release it until after the next GetGlyphFallbackFont has
+ //completed
aFontSelData.mpFontEntry = pFallbackFont;
aFontSelData.mpFontData = pFallbackFont->maFontSelData.mpFontData;
if( mpFontEntry && nFallbackLevel < MAX_FALLBACK-1)
{
// ignore fallback font if it is the same as the original font
if( mpFontEntry->maFontSelData.mpFontData == aFontSelData.mpFontData )
- {
- mpFontCache->Release( pFallbackFont );
continue;
- }
}
#if defined(HDU_DEBUG)
@@ -6324,13 +6331,14 @@
pFallback->Release();
}
- mpFontCache->Release( pFallbackFont );
-
// break when this fallback was sufficient
if( !rLayoutArgs.PrepareFallback() )
break;
}
+ if (pLastFallbackFont)
+ mpFontCache->Release( pLastFallbackFont );
+
if( pMultiSalLayout && pMultiSalLayout->LayoutText( rLayoutArgs ) )
pSalLayout = pMultiSalLayout;
Index: openoffice.org.spec
===================================================================
RCS file: /cvs/pkgs/rpms/openoffice.org/devel/openoffice.org.spec,v
retrieving revision 1.1788
retrieving revision 1.1789
diff -u -r1.1788 -r1.1789
--- openoffice.org.spec 10 Feb 2009 12:41:21 -0000 1.1788
+++ openoffice.org.spec 10 Feb 2009 17:09:01 -0000 1.1789
@@ -140,6 +140,7 @@
Patch69: openoffice.org-3.0.1.ooo98885.sw.safeindex.patch
Patch70: openoffice.org-3.0.1.ooo98909.sfx2.missingplugins.patch
Patch71: openoffice.org-3.0.1.ooo99050.sw.htmlload.patch
+Patch72: openoffice.org-3.0.1.ooo99081.vcl.dont.release.before-reuse.patch
%define python_py_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(0)")
%define instdir %{_libdir}
@@ -1606,6 +1607,7 @@
%patch69 -p1 -b .ooo98885.sw.safeindex.patch
%patch70 -p1 -b .ooo98909.sfx2.missingplugins.patch
%patch71 -p1 -R -b .ooo99050.sw.htmlload.patch
+%patch72 -p1 -R .ooo99081.vcl.dont.release.before-reuse.patch
%build
echo build start time is `date`, diskspace: `df -h . | tail -n 1`
@@ -4107,6 +4109,7 @@
- culmus-fonts => culmus-nachlieli-clm-fonts
- Resolves: rhbz#483890 revert bad change, cure worse than disease
openoffice.org-3.0.1.ooo99050.sw.htmlload.patch
+- Resolves: rhbz#484604 crash in glyph substitution
* Mon Feb 09 2009 Caolán McNamara <caolanm at redhat.com> - 1:3.0.1-15.7
- Resolves: rhbz#484055 reusable autocorrection files
- Previous message (by thread): rpms/valgrind/devel valgrind-3.4.0-debug.patch, NONE, 1.1 valgrind-3.4.0-newbu.patch, NONE, 1.1 valgrind-3.4.0-cachegrind-improvements.patch, 1.1, 1.2 valgrind-3.4.0-power5+-6.patch, 1.1, 1.2 valgrind.spec, 1.59, 1.60
- Next message (by thread): rpms/openoffice.org/F-10 openoffice.org-3.0.1.ooo99081.vcl.dont.release.before-reuse.patch, NONE, 1.1 openoffice.org.spec, 1.1716, 1.1717
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the fedora-extras-commits
mailing list