rpms/coda/devel coda-6.9.4-sname-fault.patch, NONE, 1.1 coda.spec, 1.13, 1.14

[Neil Horman]

Author: nhorman

Update of /cvs/extras/rpms/coda/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv2477

Modified Files:
	coda.spec 
Added Files:
	coda-6.9.4-sname-fault.patch 
Log Message:
Fix some sname overflows

coda-6.9.4-sname-fault.patch:
 srv.cc |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

--- NEW FILE coda-6.9.4-sname-fault.patch ---
diff -up coda-6.9.4/coda-src/vice/srv.cc.orig coda-6.9.4/coda-src/vice/srv.cc
--- coda-6.9.4/coda-src/vice/srv.cc.orig	2009-07-20 17:28:11.000000000 -0400
+++ coda-6.9.4/coda-src/vice/srv.cc	2009-07-20 17:30:32.000000000 -0400
@@ -315,7 +315,7 @@ void zombie(int sig)
 
 int main(int argc, char *argv[])
 {
-    char    sname[20];
+    char    sname[64];
     int     i;
     struct stat buff;
     PROCESS serverPid, resPid, smonPid, resworkerPid;
@@ -522,12 +522,15 @@ int main(int argc, char *argv[])
     CODA_ASSERT(LWP_CreateProcess(CallBackCheckLWP, stack*1024, LWP_NORMAL_PRIORITY,
 				  (void *)&cbwait, "CheckCallBack", &serverPid) == LWP_SUCCESS);
 
+
     for (i=0; i < auth_lwps; i++) {
+        memset(sname, 0, 64);
 	sprintf(sname, "AuthLWP-%d",i);
 	CODA_ASSERT(LWP_CreateProcess(AuthLWP, stack*1024, LWP_NORMAL_PRIORITY,
 				      (void *)&i, sname, &serverPid) == LWP_SUCCESS);
     }
     for (i=0; i < server_lwps; i++) {
+    	memset(sname, 0, 64);
 	sprintf(sname, "ServerLWP-%d",i);
 	CODA_ASSERT(LWP_CreateProcess(ServerLWP, stack*1024, LWP_NORMAL_PRIORITY,
 				      (void *)&i, sname, &serverPid) == LWP_SUCCESS);
@@ -535,16 +538,18 @@ int main(int argc, char *argv[])
 
     /* set up resolution threads */
     for (i = 0; i < 2; i++){
+	memset(sname, 0, 64);
 	sprintf(sname, "ResLWP-%d", i);
 	CODA_ASSERT(LWP_CreateProcess(ResLWP, stack*1024,
 				      LWP_NORMAL_PRIORITY, (void *)&i,
 				      sname, &resPid) == LWP_SUCCESS);
-    }
+    } 
+    memset(sname, 0, 64);
     sprintf(sname, "ResCheckSrvrLWP");
     CODA_ASSERT(LWP_CreateProcess(ResCheckServerLWP, stack*1024,
 				  LWP_NORMAL_PRIORITY, (void *)&i,
 				  sname, &resPid) == LWP_SUCCESS);
-
+    memset(sname, 0, 64);
     sprintf(sname, "ResCheckSrvrLWP_worker");
     CODA_ASSERT(LWP_CreateProcess(ResCheckServerLWP_worker, stack*1024,
 				  LWP_NORMAL_PRIORITY, (void *)&i,
@@ -557,6 +562,7 @@ int main(int argc, char *argv[])
     SLog(29, "fileserver: returning from InitvolUtil");
 
     extern void SmonDaemon(void *);
+    memset(sname, 0, 64);
     sprintf(sname, "SmonDaemon");
     CODA_ASSERT(LWP_CreateProcess(SmonDaemon, stack*1024,
 				  LWP_NORMAL_PRIORITY, (void *)&smonPid,


Index: coda.spec
===================================================================
RCS file: /cvs/extras/rpms/coda/devel/coda.spec,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -p -r1.13 -r1.14
--- coda.spec	20 Jul 2009 14:31:42 -0000	1.13
+++ coda.spec	20 Jul 2009 23:25:43 -0000	1.14
@@ -1,6 +1,6 @@
 Name:           coda
 Version:        6.9.4
-Release:        4%{?dist}
+Release:        5%{?dist}
 Summary:        Coda distributed file system
 Group:          System Environment/Daemons
 License:        GPLv2
@@ -15,6 +15,7 @@ Patch1:		coda-6.9.4-rc2-no-default-krb.p
 Patch2:		coda-6.9.4-rc2-kernel-alias.patch
 Patch3:		coda-6.9.4-gcc44.patch
 Patch4: 	coda-configure.patch
+Patch5:		coda-6.9.4-sname-fault.patch
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildRequires:  lwp-devel >= 2.5
 BuildRequires:	rpc2-devel >= 2.8
@@ -98,6 +99,9 @@ system client.
 # Convert configure script to pick up compat-readline5
 %patch4 -p1
 
+#sname overflows
+%patch5 -p1
+
 %build
 # note: remove the -I and -l here when upstream releases fix for krb5 building
 export CFLAGS="$RPM_OPT_FLAGS -I/usr/include/et"
@@ -307,6 +311,9 @@ fi
 
 
 %changelog
+* Mon Jul 20 2009 Neil Horman <nhorman at redhat.com> - 6.9.4-5
+- Fix some sname stack overflows
+
 * Mon Jul 20 2009 Neil Horman <nhorman at redhat.com> - 6.9.4-4
 - Further changes to support compat-readline5 (bz 511305)