rpms/udev/devel udev.git-055e40edc647d8ccfc27c9cd3163ab5dbf63ed6c.patch, NONE, 1.1 udev.git-0c37798916bc87d72f5f1399d9e050307901db84.patch, NONE, 1.1 udev.git-b4fa1b67f86c9555cbb41c57774761730f6b8939.patch, NONE, 1.1 udev.git-d3c8231e738dd286591c1becc2f327ed55ed89d1.patch, NONE, 1.1 udev.git-f58a9099bb2b18f3f683615324a4382b95446305.patch, NONE, 1.1 udev.spec, 1.276, 1.277
Harald Hoyer
harald at fedoraproject.org
Mon Jun 8 09:10:56 UTC 2009
Author: harald
Update of /cvs/pkgs/rpms/udev/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv15867
Modified Files:
udev.spec
Added Files:
udev.git-055e40edc647d8ccfc27c9cd3163ab5dbf63ed6c.patch
udev.git-0c37798916bc87d72f5f1399d9e050307901db84.patch
udev.git-b4fa1b67f86c9555cbb41c57774761730f6b8939.patch
udev.git-d3c8231e738dd286591c1becc2f327ed55ed89d1.patch
udev.git-f58a9099bb2b18f3f683615324a4382b95446305.patch
Log Message:
* Thu Jun 08 2009 Harald Hoyer <harald at redhat.com> 142-4
- git fix: udevadm: settle - fix timeout
- git fix: OWNER/GROUP: fix if logic
- git fix: rule-generator: cd - skip by-path links if we create by-id links
- git fix: fix possible endless loop for GOTO to non-existent LABEL
- git fix: cdrom_id: suppress ID_CDROM_MEDIA_STATE=blank for plain non-writable
CDROM media
udev.git-055e40edc647d8ccfc27c9cd3163ab5dbf63ed6c.patch:
--- NEW FILE udev.git-055e40edc647d8ccfc27c9cd3163ab5dbf63ed6c.patch ---
From: Scott James Remnant <scott at ubuntu.com>
Date: Thu, 14 May 2009 11:42:44 +0000 (+0100)
Subject: OWNER/GROUP: fix if logic
X-Git-Url: http://git.kernel.org/?p=linux%2Fhotplug%2Fudev.git;a=commitdiff_plain;h=055e40edc647d8ccfc27c9cd3163ab5dbf63ed6c
OWNER/GROUP: fix if logic
The introduction of the --resolve-names=early/never code introduced a
bug to the OWNER/GROUP lookup. Previously if the name had contained $,
lookup would have been performed later; after the patch, the key ended
up being ignored!
---
diff --git a/udev/udev-rules.c b/udev/udev-rules.c
index b8b7e52..39fe55a 100644
--- a/udev/udev-rules.c
+++ b/udev/udev-rules.c
@@ -1431,7 +1431,7 @@ static int add_rule(struct udev_rules *rules, char *line,
} else if ((rules->resolve_names > 0) && strchr("$%", value[0]) == NULL) {
uid = add_uid(rules, value);
rule_add_key(&rule_tmp, TK_A_OWNER_ID, op, NULL, &uid);
- } else if (rules->resolve_names == 0) {
+ } else if (rules->resolve_names >= 0) {
rule_add_key(&rule_tmp, TK_A_OWNER, op, value, NULL);
}
rule_tmp.rule.rule.flags = 1;
@@ -1448,7 +1448,7 @@ static int add_rule(struct udev_rules *rules, char *line,
} else if ((rules->resolve_names > 0) && strchr("$%", value[0]) == NULL) {
gid = add_gid(rules, value);
rule_add_key(&rule_tmp, TK_A_GROUP_ID, op, NULL, &gid);
- } else if (rules->resolve_names == 0) {
+ } else if (rules->resolve_names >= 0) {
rule_add_key(&rule_tmp, TK_A_GROUP, op, value, NULL);
}
rule_tmp.rule.rule.flags = 1;
udev.git-0c37798916bc87d72f5f1399d9e050307901db84.patch:
--- NEW FILE udev.git-0c37798916bc87d72f5f1399d9e050307901db84.patch ---
From: Kay Sievers <kay.sievers at vrfy.org>
Date: Wed, 13 May 2009 16:01:32 +0000 (+0200)
Subject: fix possible endless loop for GOTO to non-existent LABEL
X-Git-Url: http://git.kernel.org/?p=linux%2Fhotplug%2Fudev.git;a=commitdiff_plain;h=0c37798916bc87d72f5f1399d9e050307901db84
fix possible endless loop for GOTO to non-existent LABEL
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=526365
---
diff --git a/udev/udev-rules.c b/udev/udev-rules.c
index fac418e..b8b7e52 100644
--- a/udev/udev-rules.c
+++ b/udev/udev-rules.c
@@ -1610,6 +1610,7 @@ static int parse_file(struct udev_rules *rules, const char *filename, unsigned s
if (strcmp(label, &rules->buf[rules->tokens[j].rule.label_off]) != 0)
continue;
rules->tokens[i].key.rule_goto = j;
+ break;
}
if (rules->tokens[i].key.rule_goto == 0)
err(rules->udev, "GOTO '%s' has no matching label in: '%s'\n", label, filename);
@@ -2504,6 +2505,8 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
break;
}
case TK_A_GOTO:
+ if (cur->key.rule_goto == 0)
+ break;
cur = &rules->tokens[cur->key.rule_goto];
continue;
case TK_A_LAST_RULE:
udev.git-b4fa1b67f86c9555cbb41c57774761730f6b8939.patch:
--- NEW FILE udev.git-b4fa1b67f86c9555cbb41c57774761730f6b8939.patch ---
From: Kay Sievers <kay.sievers at vrfy.org>
Date: Thu, 14 May 2009 10:57:19 +0000 (+0200)
Subject: rule-generator: cd - skip by-path links if we create by-id links
X-Git-Url: http://git.kernel.org/?p=linux%2Fhotplug%2Fudev.git;a=commitdiff_plain;h=b4fa1b67f86c9555cbb41c57774761730f6b8939
rule-generator: cd - skip by-path links if we create by-id links
---
diff --git a/extras/rule_generator/75-cd-aliases-generator.rules b/extras/rule_generator/75-cd-aliases-generator.rules
index e357a6a..e6da010 100644
--- a/extras/rule_generator/75-cd-aliases-generator.rules
+++ b/extras/rule_generator/75-cd-aliases-generator.rules
@@ -1,6 +1,9 @@
# these rules generate rules for the /dev/{cdrom,dvd,...} symlinks
-# the path of removable devices changes frequently
-ACTION=="add", SUBSYSTEM=="block", SUBSYSTEMS=="usb|ieee1394", ENV{ID_CDROM}=="?*", ENV{GENERATED}!="?*", PROGRAM="write_cd_rules by-id", SYMLINK+="%c"
+# the "path" of usb/ieee1394 devices changes frequently, use "id"
+ACTION=="add", SUBSYSTEM=="block", SUBSYSTEMS=="usb|ieee1394", ENV{ID_CDROM}=="?*", ENV{GENERATED}!="?*", \
+ PROGRAM="write_cd_rules by-id", SYMLINK+="%c", GOTO="persistent_cd_end"
ACTION=="add", SUBSYSTEM=="block", ENV{ID_CDROM}=="?*", ENV{GENERATED}!="?*", PROGRAM="write_cd_rules", SYMLINK+="%c"
+
+LABEL="persistent_cd_end"
diff --git a/extras/rule_generator/write_cd_rules b/extras/rule_generator/write_cd_rules
index 398cd27..0d16fe6 100644
--- a/extras/rule_generator/write_cd_rules
+++ b/extras/rule_generator/write_cd_rules
@@ -97,7 +97,7 @@ choose_rules_file
link_num=$(find_next_available 'cdrom[0-9]*')
-match="ENV{ID_CDROM}==\"?*\", $RULE"
+match="SUBSYSTEM==\"block\", ENV{ID_CDROM}==\"?*\", $RULE"
comment="$ID_MODEL ($ID_PATH)"
@@ -108,6 +108,7 @@ comment="$ID_MODEL ($ID_PATH)"
write_rule "$match" "dvd$link_num"
[ "$ID_CDROM_DVD_R" -o "$ID_CDROM_DVD_RW" -o "$ID_CDROM_DVD_RAM" ] && \
write_rule "$match" "dvdrw$link_num"
+echo >> $RULES_FILE
unlock_rules_file
udev.git-d3c8231e738dd286591c1becc2f327ed55ed89d1.patch:
--- NEW FILE udev.git-d3c8231e738dd286591c1becc2f327ed55ed89d1.patch ---
From: Kay Sievers <kay.sievers at vrfy.org>
Date: Mon, 25 May 2009 22:50:45 +0000 (+0200)
Subject: cdrom_id: suppress ID_CDROM_MEDIA_STATE=blank for plain non-writable CDROM media
X-Git-Url: http://git.kernel.org/?p=linux%2Fhotplug%2Fudev.git;a=commitdiff_plain;h=d3c8231e738dd286591c1becc2f327ed55ed89d1
cdrom_id: suppress ID_CDROM_MEDIA_STATE=blank for plain non-writable CDROM media
Some broken fake cdrom drives return ID_CDROM_MEDIA_STATE=blank.
$ /lib/udev/cdrom_id -d /dev/sr1
main: probing: '/dev/sr1'
cd_inquiry: INQUIRY: [Nokia ][S60 ][1.0 ]
cd_profiles: GET CONFIGURATION: number of profiles 76
cd_profiles: current profile 0x08
cd_media_toc: READ TOC: len: 12
cd_media_toc: last track 1 starts at block 0
cd_media_info: disk type 00
ID_CDROM=1
ID_CDROM_MRW=1
ID_CDROM_MRW_W=1
ID_CDROM_MEDIA=1
ID_CDROM_MEDIA_CD=1
ID_CDROM_MEDIA_STATE=blank
Others work fine, but ID_CDROM_MEDIA_STATE is not needed for non-writable CDROM media:
$ /lib/udev/cdrom_id -d /dev/sr1
main: probing: '/dev/sr1'
cd_inquiry: INQUIRY: [SanDisk ][U3 Cruzer Micro ][8.02]
cd_profiles: GET CONFIGURATION: number of profiles 72
cd_profiles: current profile 0x08
cd_media_toc: READ TOC: len: 20
cd_media_toc: track=1 info=0x4(data) start_block=0
cd_media_toc: last track 1 starts at block 0
cd_media_info: disk type 00
ID_CDROM=1
ID_CDROM_MRW=1
ID_CDROM_MRW_W=1
ID_CDROM_MEDIA=1
ID_CDROM_MEDIA_CD=1
ID_CDROM_MEDIA_STATE=complete
ID_CDROM_MEDIA_SESSION_COUNT=1
ID_CDROM_MEDIA_TRACK_COUNT=1
ID_CDROM_MEDIA_TRACK_COUNT_DATA=1
---
diff --git a/extras/cdrom_id/cdrom_id.c b/extras/cdrom_id/cdrom_id.c
index 0d873ae..921e534 100644
--- a/extras/cdrom_id/cdrom_id.c
+++ b/extras/cdrom_id/cdrom_id.c
@@ -426,8 +426,10 @@ static int cd_media_info(struct udev *udev, int fd)
info(udev, "disk type %02x\n", header[8]);
- if ((header[2] & 3) < 4)
+ /* exclude plain CDROM, some fake cdroms return 0 for "blank" media here */
+ if (!cd_media_cd_rom && (header[2] & 3) < 4)
cd_media_state = media_status[header[2] & 3];
+
if ((header[2] & 3) != 2)
cd_media_session_next = header[10] << 8 | header[5];
cd_media_session_count = header[9] << 8 | header[4];
udev.git-f58a9099bb2b18f3f683615324a4382b95446305.patch:
--- NEW FILE udev.git-f58a9099bb2b18f3f683615324a4382b95446305.patch ---
From: Alan Jenkins <alan-jenkins at tuffmail.co.uk>
Date: Wed, 20 May 2009 14:12:22 +0000 (+0200)
Subject: udevadm: settle - fix timeout
X-Git-Url: http://git.kernel.org/?p=linux%2Fhotplug%2Fudev.git;a=commitdiff_plain;h=f58a9099bb2b18f3f683615324a4382b95446305
udevadm: settle - fix timeout
The timeout wasn't working when settle was run as root:
# udevadm control --stop-exec-queue
# udevadm trigger
# udevadm settle --timeout=1
... (hangs)
Signed-off-by: Alan Jenkins <alan-jenkins at tuffmail.co.uk>
---
diff --git a/udev/udevadm-settle.c b/udev/udevadm-settle.c
index 3b26f10..52d9c0b 100644
--- a/udev/udevadm-settle.c
+++ b/udev/udevadm-settle.c
@@ -167,6 +167,7 @@ int udevadm_settle(struct udev *udev, int argc, char *argv[])
sigprocmask(SIG_BLOCK, &mask, &oldmask);
if (udev_ctrl_send_settle(uctrl) > 0)
sigsuspend(&oldmask);
+ sigprocmask(SIG_SETMASK, &oldmask, NULL);
udev_ctrl_unref(uctrl);
}
}
Index: udev.spec
===================================================================
RCS file: /cvs/pkgs/rpms/udev/devel/udev.spec,v
retrieving revision 1.276
retrieving revision 1.277
diff -u -p -r1.276 -r1.277
--- udev.spec 8 Jun 2009 08:56:38 -0000 1.276
+++ udev.spec 8 Jun 2009 09:10:26 -0000 1.277
@@ -6,7 +6,7 @@
Summary: A userspace implementation of devfs
Name: udev
Version: 142
-Release: 3%{?dist}
+Release: 4%{?dist}
License: GPLv2
Group: System Environment/Base
Provides: udev-persistent = %{version}-%{release}
@@ -18,6 +18,12 @@ Source3: udev-post.init
Source4: fw_unit_symlinks.sh
Source5: udev.sysconfig
+Patch1: udev.git-055e40edc647d8ccfc27c9cd3163ab5dbf63ed6c.patch
+Patch2: udev.git-0c37798916bc87d72f5f1399d9e050307901db84.patch
+Patch3: udev.git-b4fa1b67f86c9555cbb41c57774761730f6b8939.patch
+Patch4: udev.git-d3c8231e738dd286591c1becc2f327ed55ed89d1.patch
+Patch5: udev.git-f58a9099bb2b18f3f683615324a4382b95446305.patch
+
ExclusiveOS: Linux
URL: http://www.kernel.org/pub/linux/utils/kernel/hotplug/udev.html
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
@@ -73,6 +79,12 @@ dynamic library, which provides access t
%prep
%setup -q
+%patch1 -p1
+%patch2 -p1
+%patch3 -p1
+%patch4 -p1
+%patch5 -p1
+
%build
%if %{with_static}
%configure --with-selinux --prefix=%{_prefix} --exec-prefix="" --sysconfdir=%{_sysconfdir} --with-libdir-name=%{_lib} --sbindir="/sbin" --enable-static
@@ -348,7 +360,15 @@ rm -rf $RPM_BUILD_ROOT
%changelog
-* Thu Jun 04 2009 Harald Hoyer <harald at redhat.com> 142-3
+* Thu Jun 08 2009 Harald Hoyer <harald at redhat.com> 142-4
+- git fix: udevadm: settle - fix timeout
+- git fix: OWNER/GROUP: fix if logic
+- git fix: rule-generator: cd - skip by-path links if we create by-id links
+- git fix: fix possible endless loop for GOTO to non-existent LABEL
+- git fix: cdrom_id: suppress ID_CDROM_MEDIA_STATE=blank for plain non-writable
+ CDROM media
+
+* Thu Jun 08 2009 Harald Hoyer <harald at redhat.com> 142-3
- delay device-mapper changes
* Fri Jun 05 2009 Bastien Nocera <bnocera at redhat.com> 142-2
More information about the fedora-extras-commits
mailing list