rpms/kernel/devel linux-2.6-ext4-print-warning-once.patch, NONE, 1.1 kernel.spec, 1.1431, 1.1432

Chuck Ebbert cebbert at fedoraproject.org
Fri Mar 13 21:43:05 UTC 2009


Author: cebbert

Update of /cvs/pkgs/rpms/kernel/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv23652

Modified Files:
	kernel.spec 
Added Files:
	linux-2.6-ext4-print-warning-once.patch 
Log Message:
Quiet down an ext4 warning message.

linux-2.6-ext4-print-warning-once.patch:

--- NEW FILE linux-2.6-ext4-print-warning-once.patch ---
From: Theodore Ts'o <tytso at mit.edu>
Date: Thu, 12 Mar 2009 16:20:01 +0000 (-0400)
Subject: ext4: Print the find_group_flex() warning only once
X-Git-Url: http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftytso%2Fext4.git;a=commitdiff_plain;h=e8eb6f8319eb2536d292fc18fe14e745c970049a

ext4: Print the find_group_flex() warning only once

This is a short-term warning, and even printk_ratelimit() can result
in too much noise in system logs.  So only print it once as a warning.

Signed-off-by: "Theodore Ts'o" <tytso at mit.edu>
---

diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 627f8c3..2d2b358 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -698,6 +698,7 @@ struct inode *ext4_new_inode(handle_t *handle, struct inode *dir, int mode)
 	struct inode *ret;
 	ext4_group_t i;
 	int free = 0;
+	static int once = 1;
 	ext4_group_t flex_group;
 
 	/* Cannot create files in a deleted directory */
@@ -719,7 +720,8 @@ struct inode *ext4_new_inode(handle_t *handle, struct inode *dir, int mode)
 		ret2 = find_group_flex(sb, dir, &group);
 		if (ret2 == -1) {
 			ret2 = find_group_other(sb, dir, &group);
-			if (ret2 == 0 && printk_ratelimit())
+			if (ret2 == 0 && once)
+				once = 0;
 				printk(KERN_NOTICE "ext4: find_group_flex "
 				       "failed, fallback succeeded dir %lu\n",
 				       dir->i_ino);


Index: kernel.spec
===================================================================
RCS file: /cvs/pkgs/rpms/kernel/devel/kernel.spec,v
retrieving revision 1.1431
retrieving revision 1.1432
diff -u -r1.1431 -r1.1432
--- kernel.spec	13 Mar 2009 20:25:35 -0000	1.1431
+++ kernel.spec	13 Mar 2009 21:42:34 -0000	1.1432
@@ -685,7 +685,9 @@
 
 # ext4 fixes
 Patch2910: linux-2.6-ext4-extent-header-check-fix.patch
-Patch2911: linux-2.6-ext4-flush-on-close.patch
+Patch2911: linux-2.6-ext4-print-warning-once.patch
+
+Patch2920: linux-2.6-ext4-flush-on-close.patch
 
 Patch9001: revert-fix-modules_install-via-nfs.patch
 
@@ -1104,6 +1106,8 @@
 
 # ext4
 ApplyPatch linux-2.6-ext4-extent-header-check-fix.patch
+ApplyPatch linux-2.6-ext4-print-warning-once.patch
+
 ApplyPatch linux-2.6-ext4-flush-on-close.patch
 
 # xfs
@@ -1816,6 +1820,9 @@
 # and build.
 
 %changelog
+* Fri Mar 13 2009 Chuck Ebbert <cebbert at redhat.com> 2.6.29-0.252.rc8
+- Quiet down an ext4 warning message.
+
 * Fri Mar 13 2009 Dave Jones <davej at redhat.com> 2.6.29-0.250.rc8
 - Fix DMA leak in Velocity TX path
 




More information about the fedora-extras-commits mailing list