rpms/gnome-disk-utility/F-12 gdu-2.28.1-nautilus-extension-fix-refs.patch, NONE, 1.1 gnome-disk-utility.spec, 1.24, 1.25

[Tomas Bzatek]

Author: tbzatek

Update of /cvs/extras/rpms/gnome-disk-utility/F-12
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv1478

Modified Files:
	gnome-disk-utility.spec 
Added Files:
	gdu-2.28.1-nautilus-extension-fix-refs.patch 
Log Message:
* Tue Oct 13 2009 Tomas Bzatek <tbzatek at redhat.com> - 2.28.0-5%{?dist}
- Fix nautilus crashes by proper object referencing


gdu-2.28.1-nautilus-extension-fix-refs.patch:
 nautilus-gdu.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

--- NEW FILE gdu-2.28.1-nautilus-extension-fix-refs.patch ---
>From e25d8ca00ce85fcf2552fa08aa3a369e4ef012d6 Mon Sep 17 00:00:00 2001
From: Tomas Bzatek <tbzatek at redhat.com>
Date: Tue, 13 Oct 2009 15:59:03 +0200
Subject: [PATCH] Nautilus extension: ref and unref objects correctly

Save reference to device as long as the menu item lives.
This caused random Nautilus crashes on device removal.
---
 src/nautilus-extension/nautilus-gdu.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/nautilus-extension/nautilus-gdu.c b/src/nautilus-extension/nautilus-gdu.c
index afbf6b8..417f3ad 100644
--- a/src/nautilus-extension/nautilus-gdu.c
+++ b/src/nautilus-extension/nautilus-gdu.c
@@ -225,8 +225,8 @@ nautilus_gdu_get_file_items (NautilusMenuProvider *provider,
                                        "nautilus-gdu");
         g_object_set_data_full (G_OBJECT (item),
                                 "gdu-device",
-                                device,
-                                (GDestroyNotify) g_object_ref);
+                                g_object_ref (device),
+                                (GDestroyNotify) g_object_unref);
         g_object_set_data_full (G_OBJECT (item),
                                 "nautilus-file",
                                 g_object_ref (nautilus_file),
-- 
1.6.5.rc2



Index: gnome-disk-utility.spec
===================================================================
RCS file: /cvs/extras/rpms/gnome-disk-utility/F-12/gnome-disk-utility.spec,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -p -r1.24 -r1.25
--- gnome-disk-utility.spec	5 Oct 2009 17:14:57 -0000	1.24
+++ gnome-disk-utility.spec	13 Oct 2009 15:28:29 -0000	1.25
@@ -13,7 +13,7 @@
 Summary: Disk management application
 Name: gnome-disk-utility
 Version: 2.28.0
-Release: 4%{?dist}
+Release: 5%{?dist}
 License: LGPLv2+
 Group: System Environment/Libraries
 URL: http://git.gnome.org/cgit/gnome-disk-utility
@@ -45,6 +45,7 @@ Patch1: 0001-Use-stock-delete-and-apply-
 Patch2: 0002-Fix-library-translations.patch
 Patch3: 0003-Use-translated-string-for-button-label.patch
 Patch4: 0004-Translate-file-system-types.patch
+Patch5: gdu-2.28.1-nautilus-extension-fix-refs.patch
 
 %description
 This package contains the Palimpsest disk management application.
@@ -104,6 +105,7 @@ develop applications with gnome-disk-uti
 %patch2 -p1 -b fix-library-translations
 %patch3 -p1 -b use-translated-string-for-button-label
 %patch4 -p1 -b translate-file-system-types
+%patch5 -p1 -b .nautilus-ext-ref-fixes
 
 %build
 %configure
@@ -220,6 +222,9 @@ fi
 %{_includedir}/gnome-disk-utility/gdu-gtk/*
 
 %changelog
+* Tue Oct 13 2009 Tomas Bzatek <tbzatek at redhat.com> - 2.28.0-5%{?dist}
+- Fix nautilus crashes by proper object referencing
+
 * Mon Oct  5 2009 Matthias Clasen <mclasen at redhat.com> - 2.28.0-4%{?dist}
 - Incorporate fixes for translation issues from the stable upstream branch