rpms/deltarpm/devel deltarpm-python-error.patch, 1.2, 1.3 deltarpm.spec, 1.28, 1.29

[Bill Nottingham]

Author: notting

Update of /cvs/extras/rpms/deltarpm/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv18836

Modified Files:
	deltarpm-python-error.patch deltarpm.spec 
Log Message:
Don't leak fds.


deltarpm-python-error.patch:
 deltarpmmodule.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

Index: deltarpm-python-error.patch
===================================================================
RCS file: /cvs/extras/rpms/deltarpm/devel/deltarpm-python-error.patch,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -p -r1.2 -r1.3
--- deltarpm-python-error.patch	9 Sep 2009 19:08:42 -0000	1.2
+++ deltarpm-python-error.patch	9 Sep 2009 19:51:22 -0000	1.3
@@ -1,6 +1,6 @@
 diff -up deltarpm-git-20090831.1/deltarpmmodule.c.foo deltarpm-git-20090831.1/deltarpmmodule.c
---- deltarpm-git-20090831.1/deltarpmmodule.c.foo	2009-09-09 13:28:37.000000000 -0400
-+++ deltarpm-git-20090831.1/deltarpmmodule.c	2009-09-09 15:03:20.000000000 -0400
+--- deltarpm-git-20090831.1/deltarpmmodule.c.foo	2009-08-31 10:17:34.000000000 -0400
++++ deltarpm-git-20090831.1/deltarpmmodule.c	2009-09-09 15:44:49.000000000 -0400
 @@ -66,13 +66,17 @@ static PyObject *doRead(PyObject *s, PyO
    int pid;
    int ipcpipe[2];
@@ -21,12 +21,15 @@ diff -up deltarpm-git-20090831.1/deltarp
  
    if ((pid = fork())) {
      FILE *readend = fdopen(ipcpipe[0], "r");
-@@ -90,7 +94,7 @@ static PyObject *doRead(PyObject *s, PyO
+@@ -90,8 +94,10 @@ static PyObject *doRead(PyObject *s, PyO
  
      readdeltarpm(filename, &d, NULL);
      PyMarshal_WriteObjectToFile(createDict(d), writend, Py_MARSHAL_VERSION);
 -    exit(0);
++    fclose(writend);
 +    _exit(0);
    }
++  close(ipcpipe[1]);
    return ret;
  }
+ 


Index: deltarpm.spec
===================================================================
RCS file: /cvs/extras/rpms/deltarpm/devel/deltarpm.spec,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -p -r1.28 -r1.29
--- deltarpm.spec	9 Sep 2009 19:08:42 -0000	1.28
+++ deltarpm.spec	9 Sep 2009 19:51:22 -0000	1.29
@@ -3,7 +3,7 @@
 Summary: Create deltas between rpms
 Name: deltarpm
 Version: 3.5
-Release: 0.git.20090831.1.2%{?dist}
+Release: 0.git.20090831.1.3%{?dist}
 License: BSD
 Group: System Environment/Base
 URL: http://gitorious.org/deltarpm/deltarpm
@@ -98,8 +98,11 @@ This package contains python bindings fo
 %{python_sitearch}/*
 
 %changelog
-* Wed Sep  9 2009 Bill Nottingham <notting at redhat.com> - 3.5-0.git.20090831.1.2
-- fix python bindings
+* Wed Sep  9 2009 Bill Nottingham <notting at redhat.com> - 3.5-0.git.20090831.1.3
+- fix python bindings to:
+  - call _exit(), not exit()
+  - properly pythonize errors
+  - not leak file descriptors
 
 * Mon Aug 31 2009 Jonathan Dieter <jdieter at lesbg.com> - 3.5-0.git.20090831.1
 - Add python bindings sub-package