Review Needed: autossh, bwm-ng, colortail, htop

[Iago Rubio]

On Tue, 2005-04-05 at 08:55 +0200, Adrian Reber wrote:
> On Mon, Apr 04, 2005 at 12:46:34PM +0200, Iago Rubio wrote:
> > On Mon, 2005-04-04 at 11:57 +0200, Adrian Reber wrote:
> > > I would like to import following packages into CVS.
> > > 
> > > http://lisas.de/~adrian/rpm/autossh-1.3-1.src.rpm
> > > http://lisas.de/~adrian/rpm/bwm-ng-0.5-3.src.rpm
> > > http://lisas.de/~adrian/rpm/colortail-0.3.0-1.src.rpm
> > > http://lisas.de/~adrian/rpm/htop-0.5-2.src.rpm
> > > 
> > > All this packages are from Dag and I would like to keep the specfiles as
> > > close as possible to Dag's version if possible.
> > 
> > It will depend on how close Dag's spec files are to Fedora's packaging
> > guidelines.
> 
> I would say the specs are pretty close to the guidelines. 

I agree with you.

> I have extracted the specs for easier reviews:


> http://lisas.de/~adrian/rpm/autossh.spec
* Consider to use -p to preserve timestamps on "install" invocation.
* Consider to use the preferred Fedora's buildroot:
  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Mixed variables and macros (optimization flags), please stuck with one
or another, but not both.

> http://lisas.de/~adrian/rpm/bwm-ng.spec
* Consider to use -p to preserve timestamps on "install" invocation.
* Consider to use the preferred Fedora's buildroot:
  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

> http://lisas.de/~adrian/rpm/colortail.spec
* Consider to use the preferred Fedora's buildroot:
  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

> http://lisas.de/~adrian/rpm/htop.spec
* Consider to use -p to preserve timestamps on "install" invocation.
* Consider to use the preferred Fedora's buildroot:
  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Consider to strip out irrelevant documentation: INSTALL and the
philosophical NEWS file.

"See the ChangeLog for news of the past.
 See the TODO list for news of the future.
 Run the program for news of the present"

:)

All packages rebuilds and installs fine.


Related guidelines:

Timestamps
http://fedoraproject.org/wiki/PackagingGuidelines#head-
c04ed1238a14de2b02d7fd14a7e9605bb1b10b96

Variables and macros ($RPM_OPT_FLAGS)
http://fedoraproject.org/wiki/PackagingGuidelines#head-
d0ada6130cf40be1244d34cc44fc38d34dd00db8

Buildroot
http://fedoraproject.org/wiki/PackagingGuidelines#head-29431b817fcad64ff7483ca37fb8d69bd31c0da7

Documentation
http://fedoraproject.org/wiki/PackagingGuidelines#head-9e9cf3221a30246219863f1d2366e36cb580debc


Regards.
-- 
Iago Rubio