Request for Preview: INADYN

[Michael Schwendt]

On Sun, 10 Apr 2005 19:35:37 +0200, Jochen Schmitt wrote:

> On Thu, 07 Apr 2005 16:37:07 -0400, you wrote:
> 
> >On Thu, 2005-04-07 at 19:19 +0200, Jochen Schmitt wrote:
> >> http://www.herr-schmitt.de/pub/inadyn/inadyn-1.90-0.2.src.rpm
> >> 
> >> is a lightwight DynDNS client wrttien in puer C.
> >
> >? Name and version macros at the top
> >? Incorrect release number
> >- Superflous Epoch 0
> >- Summary contains the package name
> >- What happened to %setup?
> >- Doesn't remove the buildroot at the beginning of %install
> >- No modes on install
> >- Doesn't use macros throughout %install
> >- Don't create %{_docdir} manually
> >- No changelog
> >
> >Corrected spec file is attached.
> 
> Thank you for your comments.
> 
> I have modifiy the %setup macro to make clear, to which file the
> %setup macro is related.
> 
> I have uploaded the corrected Source RPM to
> 
> http://www.herr-schmitt.de/pub/inadyn/inadyn-1.90-2.src.rpm

Some corrections:

--- inadyn.spec.orig	2005-04-10 19:43:02.000000000 +0200
+++ inadyn.spec	2005-04-10 19:46:57.000000000 +0200
@@ -5,7 +5,7 @@
 
 Group:          System Environment/Daemons
 License:        GPL
-URL:            http://inadyn.ina-tech.net</a>
+URL:            http://inadyn.ina-tech.net
 Source0:        inadyn.v%{version}.zip
 Source1:        inadyn.conf
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
@@ -17,10 +17,10 @@
 is running INADYN.
 
 %prep
-%setup0 -q -c
+%setup -q -c
 
 %build
-make -f makefile.linux
+make -f makefile.linux CFLAGS="$RPM_OPT_FLAGS"
 
 %install
 rm -rf $RPM_BUILD_ROOT
@@ -30,8 +30,8 @@
 
 mkdir -p $RPM_BUILD_ROOT%{_mandir}/man5
 mkdir -p $RPM_BUILD_ROOT%{_mandir}/man8
-install -m 0644 man/inadyn.8 $RPM_BUILD_ROOT%{_mandir}/man8
-install -m 0644 man/inadyn.conf.5 $RPM_BUILD_ROOT%{_mandir}/man5
+install -p -m 0644 man/inadyn.8 $RPM_BUILD_ROOT%{_mandir}/man8
+install -p -m 0644 man/inadyn.conf.5 $RPM_BUILD_ROOT%{_mandir}/man5
 
 mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}
 install -p -m 0600 %{SOURCE1} $RPM_BUILD_ROOT%{_sysconfdir}
@@ -44,7 +44,7 @@
 %doc readme.html
 %{_sbindir}/inadyn
 %{_mandir}/man*/*
-%config /etc/inadyn.conf
+%config %{_sysconfdir}/inadyn.conf
 
 %changelog
 * Sun Apr 10 2005 Jochen Schmitt <Jochen herr-schmitt de> 1.90-2