Review: nmh

[Ignacio Vazquez-Abrams]

On Wed, 2005-04-13 at 22:23 -0400, Josh Bressers wrote:
> http://people.redhat.com/bressers/nmh/

! Redefining built-in macros is a Bad Idea
- "freeware" is not a license
- Needs db4-devel in BR
- Doesn't own its lib dir.
- Several files should be included in %doc: ChangeLog, COPYRIGHT,
README, doc/* (except Makefile* of course)
- [E:]V-R on the changelog entry

-- 
Ignacio Vazquez-Abrams <ivazquez at ivazquez.net>
http://fedora.ivazquez.net/

gpg --keyserver hkp://subkeys.pgp.net --recv-key 38028b72
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050413/c6db3c5d/attachment.sig>