Request for Review: hula
Chris Ricker
kaboom at oobleck.net
Sat Apr 30 20:30:09 UTC 2005
On Thu, 28 Apr 2005, Kevin Gray wrote:
> Just another request for review of hula. I didnt give a link to the actual
> package last time. It can be downloaded at http://files.iprone.com/.
Just some random thoughts from looking at the package:
* usually the /usr/lib/lib*.so links go in the -devel package and only the
lib*.so.* stuff in the runtime package
* change the init script to
# chkconfig: - 86 16
Just because someone installed the program doesn't mean it should be
autorun at boot, especially when it opens up half the ports on the system
and runs as root :-)
* really should be built to run as a non-root user
./autogen.sh --with-user=hula
add the hula user and group in %pre
* a lot of the paths look odd. /var/netmail? /var/mdb? And none of that
is in the spec %files?
* cert generation seems broken. If your IP is 1.2.3.4, the generated cert
is for host 4.3.2.1
* shipping with a default admin account and password (admin / hula) is not
a good idea
later,
chris
More information about the fedora-extras-list
mailing list