Review: python-elementtree, python-kid, repoview

[Ignacio Vazquez-Abrams]

On Wed, 2005-03-30 at 10:28 -0500, Konstantin Ryabitsev wrote:
> python-elementtree

? Is it necessary to unzip %SOURCE1 explicitly or will passing -a 1 to
%setup work?
? Why are you using the zip files instead of the tarballs?
+ URL and sources look good.
+ Ownership looks good.
+ Builds as non-root on i386.

> python-kid

+ URL and sources look good.
+ Ownership looks good.
+ Builds as non-root on i386

> repoview

? Is sed as a BuildRequires overkill?
+ URL and sources look good.
+ Ownership looks good.
+ Builds as non-root on i386.

So just 3 questions here to answer AFAICT.

-- 
Ignacio Vazquez-Abrams <ivazquez at ivazquez.net>
http://fedora.ivazquez.net/

gpg --keyserver hkp://subkeys.pgp.net --recv-key 38028b72
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050404/b71fec08/attachment.sig>